Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiup: optimize some mirror subcommands #1331

Merged
merged 3 commits into from
May 6, 2021

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

  • Optimize some help messages and command outputs to better describe what's going on when users try to initialize a new repository
  • Extend relative paths to absolute ones on mirror set

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

tiup: optimize some mirror subcommands

@AstroProfundis AstroProfundis added category/usability Categorizes issue or PR as a usability enhancement. component/tiup Issues about the TiUP package management component itself labels Apr 27, 2021
@AstroProfundis AstroProfundis added this to the v1.4.3 milestone Apr 27, 2021
@AstroProfundis AstroProfundis self-assigned this Apr 27, 2021
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 27, 2021
@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2021

Codecov Report

Merging #1331 (503b16b) into master (334c38a) will increase coverage by 30.06%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1331       +/-   ##
===========================================
+ Coverage   25.86%   55.93%   +30.06%     
===========================================
  Files         264      290       +26     
  Lines       19703    21580     +1877     
===========================================
+ Hits         5097    12070     +6973     
+ Misses      13825     7618     -6207     
- Partials      781     1892     +1111     
Flag Coverage Δ
cluster 43.28% <ø> (?)
dm 25.63% <ø> (?)
integrate 50.36% <71.42%> (+34.61%) ⬆️
playground 14.47% <ø> (?)
tiup 15.79% <71.42%> (+0.04%) ⬆️
unittest 22.42% <7.14%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/mirror.go 48.93% <71.42%> (+0.32%) ⬆️
pkg/cluster/api/error.go 75.00% <0.00%> (-5.00%) ⬇️
pkg/cluster/operation/operation.go 78.26% <0.00%> (ø)
pkg/logger/logger.go 100.00% <0.00%> (ø)
pkg/cluster/operation/telemetry.go 0.00% <0.00%> (ø)
components/playground/instance/process.go 81.39% <0.00%> (ø)
components/playground/instance/pump.go 0.00% <0.00%> (ø)
components/playground/instance/tiflash.go 59.09% <0.00%> (ø)
pkg/cluster/operation/destroy.go 56.61% <0.00%> (ø)
pkg/logger/debug.go 16.66% <0.00%> (ø)
... and 211 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 334c38a...503b16b. Read the comment docs.

@lucklove
Copy link
Member

lucklove commented May 6, 2021

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 6, 2021
@lucklove
Copy link
Member

lucklove commented May 6, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c1b57a4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 6, 2021
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed status/can-merge Indicates a PR has been approved by a committer. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 6, 2021
@AstroProfundis
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 503b16b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 6, 2021
@ti-chi-bot ti-chi-bot merged commit 54ac4d5 into pingcap:master May 6, 2021
@AstroProfundis AstroProfundis deleted the update-init branch May 6, 2021 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category/usability Categorizes issue or PR as a usability enhancement. component/tiup Issues about the TiUP package management component itself size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants