-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set prof_active to false #1361
set prof_active to false #1361
Conversation
As discussed in tikv/tikv#10150, this option has brought some problems like tikv/tikv#10131 and other issues report (on asktug). And it could also cause performance regression (though, it seems not to be measuable). Signed-off-by: YangKeao <keao.yang@yahoo.com>
Codecov Report
@@ Coverage Diff @@
## master #1361 +/- ##
==========================================
+ Coverage 25.38% 33.43% +8.04%
==========================================
Files 265 244 -21
Lines 20462 19485 -977
==========================================
+ Hits 5194 6514 +1320
+ Misses 14471 11754 -2717
- Partials 797 1217 +420
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Introduced in #1272 |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 8b41efa
|
As discussed in tikv/tikv#10150, this option has brought some problems like tikv/tikv#10131 and other issues report (on asktug). And it could also cause performance regression (though, it seems not to be measuable).
I haven't tested whether it would work well, because of #1360.
Signed-off-by: YangKeao keao.yang@yahoo.com