-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: fix broken depends and update #1362
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1362 +/- ##
===========================================
+ Coverage 25.38% 54.43% +29.04%
===========================================
Files 265 290 +25
Lines 20464 22346 +1882
===========================================
+ Hits 5194 12163 +6969
+ Misses 14473 8276 -6197
- Partials 797 1907 +1110
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@YangKeao: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 4b07581
|
What problem does this PR solve?
Fix #1360 and update some depends
What is changed and how it works?
client
andbench
to dedicated Go packages to avoid dependency conflictsusql
to remove dependency ofxoutil
etcd
to latest to avoid conflict ofusql
go mod tidy
Check List
Tests
Release notes: