-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster: make two configs in cdc spec editable #1380
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 925d3b2
|
Codecov Report
@@ Coverage Diff @@
## master #1380 +/- ##
===========================================
+ Coverage 25.33% 54.20% +28.86%
===========================================
Files 265 290 +25
Lines 20517 22400 +1883
===========================================
+ Hits 5198 12141 +6943
+ Misses 14519 8350 -6169
- Partials 800 1909 +1109
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
What problem does this PR solve?
gc-ttl
andtz
should be editable in the command line parameters of cdc serverWhat is changed and how it works?
add
vaildate:xx:editable
to these two parametersCheck List
Tests
Release notes: