Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: make two configs in cdc spec editable #1380

Merged
merged 1 commit into from
May 24, 2021

Conversation

amyangfei
Copy link
Contributor

@amyangfei amyangfei commented May 24, 2021

What problem does this PR solve?

gc-ttl and tz should be editable in the command line parameters of cdc server

What is changed and how it works?

add vaildate:xx:editable to these two parameters

Check List

Tests

  • Unit test
  • Integration test

Release notes:

Make `tc-ttl` and `tz` editable in cdc server spec

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 24, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 24, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 925d3b2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 24, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2021

Codecov Report

Merging #1380 (925d3b2) into master (2faf4c9) will increase coverage by 28.86%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1380       +/-   ##
===========================================
+ Coverage   25.33%   54.20%   +28.86%     
===========================================
  Files         265      290       +25     
  Lines       20517    22400     +1883     
===========================================
+ Hits         5198    12141     +6943     
+ Misses      14519     8350     -6169     
- Partials      800     1909     +1109     
Flag Coverage Δ
cluster 41.88% <ø> (?)
dm 24.61% <ø> (?)
integrate 48.74% <ø> (+33.16%) ⬆️
playground 13.80% <ø> (?)
tiup 15.57% <ø> (ø)
unittest 21.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/spec/cdc.go 75.75% <ø> (+72.72%) ⬆️
pkg/cluster/operation/destroy.go 56.61% <0.00%> (ø)
components/playground/instance/instance.go 45.45% <0.00%> (ø)
pkg/cluster/operation/telemetry.go 0.00% <0.00%> (ø)
pkg/cluster/operation/action.go 64.55% <0.00%> (ø)
components/playground/instance/pump.go 0.00% <0.00%> (ø)
components/playground/instance/tikv_config.go 100.00% <0.00%> (ø)
pkg/cluster/operation/scale_in.go 58.27% <0.00%> (ø)
pkg/cluster/operation/download.go 36.84% <0.00%> (ø)
components/playground/instance/process.go 81.39% <0.00%> (ø)
... and 210 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2faf4c9...925d3b2. Read the comment docs.

@ti-chi-bot ti-chi-bot merged commit 98eac18 into pingcap:master May 24, 2021
@amyangfei amyangfei deleted the cdc-config branch May 24, 2021 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants