-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the issue that it may panic when user try to list expired component #1391
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1391 +/- ##
==========================================
- Coverage 25.27% 15.50% -9.77%
==========================================
Files 266 149 -117
Lines 20586 12837 -7749
==========================================
- Hits 5204 1991 -3213
+ Misses 14582 10338 -4244
+ Partials 800 508 -292
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 4417be5
|
What problem does this PR solve?
When a user try to list a component that's expired with the command
tiup list <component>
, it may panic if the component manifest has already been downloaded before.What is changed and how it works?
Treat the expired component as expired
Check List
Tests
Code changes
Side effects
Related changes
Release notes: