cluster: fix tikv not upgraded on error increasing schedule limit

[AstroProfundis]

What problem does this PR solve?

The upgrade process of TiKV nodes may be skipped unexpectedly if increasing schedule limit failed

Check List

Tests

• Manual test (add detailed scripts or steps below)

Related changes

• Need to cherry-pick to the release branch

Release notes:

cluster: fix tikv not upgraded on error increasing schedule limit

[lucklove]

/lgtm

[ti-chi-bot]

@lucklove: Please use GitHub review feature instead of /lgtm [cancel] when you want to submit review to the pull request.
For how to use GitHub review feature, see also this document provided by GitHub.

For the reason we drop support to the commands, see also this page.
This reply is being used as a temporary reply during the migration of review process and will be removed on July 1st.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[lucklove]

/merge

[ti-chi-bot]

@lucklove: /merge in this pull request requires 1 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[AstroProfundis]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: bfacff3

[codecov-commenter]

Codecov Report

Merging #1401 (bfacff3) into master (b12ae28) will increase coverage by 27.22%.
The diff coverage is 20.00%.

@@             Coverage Diff             @@
##           master    #1401       +/-   ##
===========================================
+ Coverage   25.33%   52.56%   +27.22%     
===========================================
  Files         266      291       +25     
  Lines       20611    22494     +1883     
===========================================
+ Hits         5222    11824     +6602     
+ Misses      14586     8749     -5837     
- Partials      803     1921     +1118     

Flag	Coverage Δ
cluster	39.19% <20.00%> (?)
dm	24.56% <0.00%> (?)
integrate	46.76% <20.00%> (+31.27%)	⬆️
playground	13.73% <ø> (?)
tiup	15.49% <ø> (ø)
unittest	21.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/cluster/operation/upgrade.go	57.27% <20.00%> (ø)
components/playground/instance/tikv.go	67.34% <0.00%> (ø)
pkg/cluster/operation/telemetry.go	0.00% <0.00%> (ø)
pkg/cluster/operation/operation.go	78.26% <0.00%> (ø)
pkg/cluster/operation/destroy.go	54.23% <0.00%> (ø)
components/playground/instance/pump.go	0.00% <0.00%> (ø)
pkg/cluster/operation/systemd.go	70.00% <0.00%> (ø)
pkg/logger/debug.go	16.66% <0.00%> (ø)
components/playground/instance/pd.go	73.91% <0.00%> (ø)
components/playground/instance/instance.go	45.45% <0.00%> (ø)
... and 207 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b12ae28...bfacff3. Read the comment docs.