Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cluster: add deploy user to display output #1409

Merged
merged 3 commits into from
Jun 8, 2021
Merged

cluster: add deploy user to display output #1409

merged 3 commits into from
Jun 8, 2021

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

Show deploy user in display output.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Related changes

  • Need to cherry-pick to the release branch

Release notes:

cluster: add deploy user to display output

@AstroProfundis AstroProfundis added category/usability Categorizes issue or PR as a usability enhancement. component/cluster Issues about the tiup-cluster component component/dm Issues about the tiup-dm component labels Jun 7, 2021
@AstroProfundis AstroProfundis added this to the v1.5.0 milestone Jun 7, 2021
@AstroProfundis AstroProfundis self-assigned this Jun 7, 2021
@ti-chi-bot ti-chi-bot requested a review from july2993 June 7, 2021 08:08
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 7, 2021
lucklove
lucklove approved these changes Jun 8, 2021
View reviewed changes
Copy link
Member

@lucklove lucklove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 8, 2021
@AstroProfundis
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8be570b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 8, 2021
@ti-chi-bot ti-chi-bot merged commit d2b292c into pingcap:master Jun 8, 2021
@AstroProfundis AstroProfundis deleted the display-user branch June 8, 2021 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucklove lucklove lucklove approved these changes

@july2993 july2993 Awaiting requested review from july2993

Assignees

@AstroProfundis AstroProfundis

Labels
category/usability Categorizes issue or PR as a usability enhancement. component/cluster Issues about the tiup-cluster component component/dm Issues about the tiup-dm component size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AstroProfundis @ti-chi-bot @lucklove