Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix release build #1419

Merged
merged 1 commit into from
Jun 9, 2021
Merged

*: fix release build #1419

merged 1 commit into from
Jun 9, 2021

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

Fix build error in release CI

Tests

  • Integration test

Release notes:

NONE

@AstroProfundis AstroProfundis added this to the v1.5.0 milestone Jun 9, 2021
@AstroProfundis AstroProfundis self-assigned this Jun 9, 2021
@ti-chi-bot ti-chi-bot requested a review from lucklove June 9, 2021 04:14
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 9, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 9, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2021

Codecov Report

Merging #1419 (8c97ef6) into master (94b0154) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1419   +/-   ##
=======================================
  Coverage   25.32%   25.32%           
=======================================
  Files         266      266           
  Lines       20621    20621           
=======================================
  Hits         5223     5223           
  Misses      14595    14595           
  Partials      803      803           
Flag Coverage Δ
integrate 15.49% <ø> (ø)
tiup 15.49% <ø> (ø)
unittest 21.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94b0154...8c97ef6. Read the comment docs.

@AstroProfundis AstroProfundis merged commit 4f5dacc into master Jun 9, 2021
@AstroProfundis AstroProfundis deleted the ci/gh-fix-release branch June 9, 2021 04:23
AstroProfundis added a commit that referenced this pull request Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants