Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec: fix cdc data dir version issue #1421

Merged
merged 2 commits into from
Jun 10, 2021

Conversation

3AceShowHand
Copy link
Contributor

What problem does this PR solve?

solve the problem that makes tiup deploy cdc v5.0.0 failed

What is changed and how it works?

adjust the version check logic, add new tests

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

Release notes:

NONE

NONE

@ti-chi-bot ti-chi-bot requested a review from lonng June 10, 2021 11:32
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 10, 2021
@AstroProfundis AstroProfundis added component/cluster Issues about the tiup-cluster component type/bug-fix Categorizes PR as a bug-fix labels Jun 10, 2021
@AstroProfundis AstroProfundis added this to the v1.5.1 milestone Jun 10, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 10, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c212193

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 10, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2021

Codecov Report

Merging #1421 (f934ef8) into master (4f5dacc) will increase coverage by 24.51%.
The diff coverage is 16.66%.

❗ Current head f934ef8 differs from pull request most recent head c212193. Consider uploading reports for the commit c212193 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1421       +/-   ##
===========================================
+ Coverage   25.32%   49.84%   +24.51%     
===========================================
  Files         266      279       +13     
  Lines       20621    22085     +1464     
===========================================
+ Hits         5223    11008     +5785     
+ Misses      14595     9331     -5264     
- Partials      803     1746      +943     
Flag Coverage Δ
cluster 41.78% <16.66%> (?)
dm 18.22% <0.00%> (?)
integrate 46.42% <16.66%> (+30.93%) ⬆️
tiup 15.48% <0.00%> (-0.01%) ⬇️
unittest 21.65% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/template/scripts/cdc.go 56.25% <16.66%> (+56.25%) ⬆️
components/dm/task/update_dm_meta.go 0.00% <0.00%> (ø)
pkg/cluster/operation/download.go 36.84% <0.00%> (ø)
pkg/cluster/operation/action.go 64.55% <0.00%> (ø)
pkg/logger/debug.go 16.66% <0.00%> (ø)
pkg/cluster/operation/operation.go 78.26% <0.00%> (ø)
pkg/cluster/operation/check.go 46.70% <0.00%> (ø)
pkg/logger/logger.go 100.00% <0.00%> (ø)
pkg/logger/audit.go 53.33% <0.00%> (ø)
pkg/cluster/operation/telemetry.go 0.00% <0.00%> (ø)
... and 180 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f5dacc...c212193. Read the comment docs.

@ti-chi-bot ti-chi-bot merged commit c62b5b2 into pingcap:master Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/cluster Issues about the tiup-cluster component size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bug-fix Categorizes PR as a bug-fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants