-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spec: fix cdc data dir version issue #1421
spec: fix cdc data dir version issue #1421
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: c212193
|
Codecov Report
@@ Coverage Diff @@
## master #1421 +/- ##
===========================================
+ Coverage 25.32% 49.84% +24.51%
===========================================
Files 266 279 +13
Lines 20621 22085 +1464
===========================================
+ Hits 5223 11008 +5785
+ Misses 14595 9331 -5264
- Partials 803 1746 +943
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
What problem does this PR solve?
solve the problem that makes tiup deploy cdc v5.0.0 failed
What is changed and how it works?
adjust the version check logic, add new tests
Check List
Tests
Code changes
Side effects
Related changes
Release notes:
NONE