Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster,dm: auto detect cpu arch #1423

Merged
merged 14 commits into from
Jun 17, 2021

Conversation

9547
Copy link
Contributor

@9547 9547 commented Jun 12, 2021

What problem does this PR solve?

Implement #1397

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 12, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2021

Codecov Report

Merging #1423 (acc63e6) into master (342f044) will increase coverage by 16.85%.
The diff coverage is 65.21%.

❗ Current head acc63e6 differs from pull request most recent head e6cab3c. Consider uploading reports for the commit e6cab3c to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1423       +/-   ##
===========================================
+ Coverage   25.29%   42.14%   +16.85%     
===========================================
  Files         264      288       +24     
  Lines       20660    22590     +1930     
===========================================
+ Hits         5226     9521     +4295     
+ Misses      14631    11547     -3084     
- Partials      803     1522      +719     
Flag Coverage Δ
cluster 28.54% <52.74%> (?)
integrate 36.03% <52.74%> (+20.58%) ⬆️
playground 13.70% <0.00%> (?)
tiup 15.42% <0.00%> (-0.04%) ⬇️
unittest 21.58% <13.04%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/dm/spec/topology_dm.go 73.78% <0.00%> (-0.20%) ⬇️
pkg/cluster/manager/check.go 0.00% <0.00%> (ø)
pkg/cluster/manager/deploy.go 65.53% <0.00%> (+65.53%) ⬆️
pkg/cluster/manager/scale_out.go 45.26% <42.85%> (+36.66%) ⬆️
pkg/cluster/spec/spec.go 75.61% <58.62%> (+17.70%) ⬆️
pkg/cluster/manager/manager.go 72.72% <77.77%> (+72.72%) ⬆️
pkg/cluster/ansible/import.go 39.04% <100.00%> (+0.84%) ⬆️
pkg/cluster/ansible/inventory.go 56.00% <100.00%> (+1.25%) ⬆️
pkg/cluster/operation/check.go 0.00% <0.00%> (ø)
pkg/cluster/operation/scale_in.go 40.39% <0.00%> (ø)
... and 152 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 342f044...e6cab3c. Read the comment docs.

Copy link
Contributor

@AstroProfundis AstroProfundis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if user specified an arch different with uname -m reports? e.g., user sets amd64 in the topology file, but the probe shows as aarch64. Will the topology changed by the probe result?

pkg/cluster/manager/manager.go Show resolved Hide resolved
pkg/cluster/manager/manager.go Show resolved Hide resolved
pkg/cluster/spec/spec.go Outdated Show resolved Hide resolved
@9547
Copy link
Contributor Author

9547 commented Jun 15, 2021

What if user specified an arch different with uname -m reports? e.g., user sets amd64 in the topology file, but the probe shows as aarch64. Will the topology changed by the probe result?

We only detect those nodes whose arch was not specified.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 16, 2021
jsvisa added 14 commits June 16, 2021 22:37
Signed-off-by: 9547 <nivefive9547@gmail.com>
Signed-off-by: 9547 <nivefive9547@gmail.com>
Signed-off-by: 9547 <nivefive9547@gmail.com>
Signed-off-by: 9547 <nivefive9547@gmail.com>
Signed-off-by: 9547 <nivefive9547@gmail.com>
Signed-off-by: 9547 <nivefive9547@gmail.com>
Signed-off-by: 9547 <nivefive9547@gmail.com>
Signed-off-by: 9547 <nivefive9547@gmail.com>
Signed-off-by: 9547 <nivefive9547@gmail.com>
Signed-off-by: 9547 <nivefive9547@gmail.com>
Signed-off-by: 9547 <nivefive9547@gmail.com>
Signed-off-by: 9547 <nivefive9547@gmail.com>
Signed-off-by: 9547 <nivefive9547@gmail.com>
Signed-off-by: 9547 <nivefive9547@gmail.com>
@9547 9547 force-pushed the feature/auto-detect-cpu-arch branch from ea17b6d to e6cab3c Compare June 16, 2021 15:36
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 16, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 17, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e6cab3c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 17, 2021
@ti-chi-bot ti-chi-bot merged commit 61b98df into pingcap:master Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants