-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster,dm: auto detect cpu arch #1423
cluster,dm: auto detect cpu arch #1423
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1423 +/- ##
===========================================
+ Coverage 25.29% 42.14% +16.85%
===========================================
Files 264 288 +24
Lines 20660 22590 +1930
===========================================
+ Hits 5226 9521 +4295
+ Misses 14631 11547 -3084
- Partials 803 1522 +719
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if user specified an arch different with uname -m
reports? e.g., user sets amd64
in the topology file, but the probe shows as aarch64
. Will the topology changed by the probe result?
We only detect those nodes whose arch was not specified. |
Signed-off-by: 9547 <nivefive9547@gmail.com>
Signed-off-by: 9547 <nivefive9547@gmail.com>
Signed-off-by: 9547 <nivefive9547@gmail.com>
Signed-off-by: 9547 <nivefive9547@gmail.com>
Signed-off-by: 9547 <nivefive9547@gmail.com>
Signed-off-by: 9547 <nivefive9547@gmail.com>
Signed-off-by: 9547 <nivefive9547@gmail.com>
Signed-off-by: 9547 <nivefive9547@gmail.com>
Signed-off-by: 9547 <nivefive9547@gmail.com>
Signed-off-by: 9547 <nivefive9547@gmail.com>
Signed-off-by: 9547 <nivefive9547@gmail.com>
Signed-off-by: 9547 <nivefive9547@gmail.com>
Signed-off-by: 9547 <nivefive9547@gmail.com>
Signed-off-by: 9547 <nivefive9547@gmail.com>
ea17b6d
to
e6cab3c
Compare
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: e6cab3c
|
What problem does this PR solve?
Implement #1397
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release notes: