Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue that slow log position not change with LogDir #1441

Merged
merged 1 commit into from
Jun 22, 2021

Conversation

lucklove
Copy link
Member

Fix #1440

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot requested a review from july2993 June 22, 2021 05:52
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 22, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2021

Codecov Report

Merging #1441 (ef9e9b5) into master (2bba748) will decrease coverage by 3.57%.
The diff coverage is n/a.

❗ Current head ef9e9b5 differs from pull request most recent head b582367. Consider uploading reports for the commit b582367 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1441      +/-   ##
==========================================
- Coverage   25.23%   21.65%   -3.58%     
==========================================
  Files         264      165      -99     
  Lines       20745    14571    -6174     
==========================================
- Hits         5235     3156    -2079     
+ Misses      14707    10707    -4000     
+ Partials      803      708      -95     
Flag Coverage Δ
integrate 21.65% <ø> (+6.23%) ⬆️
playground 13.70% <ø> (?)
tiup 15.42% <ø> (ø)
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
embed/embed.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/spec/validate.go 0.00% <0.00%> (-89.97%) ⬇️
pkg/cluster/executor/checkpoint.go 0.00% <0.00%> (-82.61%) ⬇️
pkg/utils/diff.go 0.00% <0.00%> (-82.50%) ⬇️
pkg/meta/err.go 0.00% <0.00%> (-81.25%) ⬇️
pkg/cluster/api/error.go 0.00% <0.00%> (-80.00%) ⬇️
pkg/cluster/spec/parse_topology.go 0.00% <0.00%> (-78.47%) ⬇️
pkg/telemetry/node_info.go 0.00% <0.00%> (-73.34%) ⬇️
pkg/telemetry/scrub.go 0.00% <0.00%> (-66.67%) ⬇️
pkg/utils/error.go 0.00% <0.00%> (-63.64%) ⬇️
... and 180 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bba748...b582367. Read the comment docs.

Copy link
Contributor

@9547 9547 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link
Member

@9547: Please use GitHub review feature instead of /lgtm [cancel] when you want to submit review to the pull request.
For how to use GitHub review feature, see also this document provided by GitHub.

For the reason we drop support to the commands, see also this page.
This reply is being used as a temporary reply during the migration of review process and will be removed on July 1st.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 9547

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 22, 2021
@AstroProfundis AstroProfundis added this to the v1.5.2 milestone Jun 22, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b582367

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 22, 2021
@ti-chi-bot ti-chi-bot merged commit 857162f into pingcap:master Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modified “log.slow-query-file” do not take effect when using tiup
5 participants