-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blackbox: fix the issue of TLS handshake error in tls cluster #1443
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1443 +/- ##
==========================================
+ Coverage 25.13% 28.58% +3.45%
==========================================
Files 264 245 -19
Lines 20826 20533 -293
==========================================
+ Hits 5235 5870 +635
+ Misses 14788 13555 -1233
- Partials 803 1108 +305
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
47b8c7c
to
58cb47d
Compare
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 58cb47d
|
What problem does this PR solve?
I've deployed a TLS supported cluster, found the PD and TiKV has may TLS related error/warn logs:
Those error message disturbed me for a while, after digging for a while, found it's caused by blackbox_exporter and Prometheus.
tiup/embed/templates/config/prometheus.yml.tpl
Lines 274 to 278 in 857162f
tiup/embed/templates/config/blackbox.yml
Lines 10 to 11 in 857162f
In Prometheus, we infer port viability by port_prober, but by default, this is connected directly through TCP by
tcp_connect
module, and the above logs are due to the lack of certificates when TLS is enabled. Therefore, here I introduce thetls_connect
module, which is used to detect TLSWhat is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release notes: