Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: adjust error message of selinux check #1476

Merged
merged 2 commits into from
Jul 14, 2021

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

Close #1449

What is changed and how it works?

Adjust the error message to avoid formatting issues

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Related changes

  • Need to cherry-pick to the release branch

Release notes:

NONE

@AstroProfundis AstroProfundis added this to the v1.5.3 milestone Jul 8, 2021
@AstroProfundis AstroProfundis self-assigned this Jul 8, 2021
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 8, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2021

Codecov Report

Merging #1476 (8b0ec4b) into master (00548a9) will decrease coverage by 1.09%.
The diff coverage is 59.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1476      +/-   ##
==========================================
- Coverage   56.71%   55.62%   -1.10%     
==========================================
  Files         242      292      +50     
  Lines       17469    25917    +8448     
==========================================
+ Hits         9908    14416    +4508     
- Misses       6265     9488    +3223     
- Partials     1296     2013     +717     
Flag Coverage Δ
cluster 42.99% <63.31%> (?)
coverage ?
dm 26.42% <42.18%> (?)
integrate 50.38% <50.21%> (?)
playground 14.23% <52.88%> (?)
tiup 16.16% <49.30%> (?)
unittest 22.82% <25.87%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/telemetry.go 27.41% <0.00%> (ø)
components/cluster/command/import.go 19.10% <0.00%> (ø)
components/cluster/command/telemetry.go 24.00% <0.00%> (ø)
components/playground/instance/drainer.go 0.00% <0.00%> (ø)
components/playground/instance/pump.go 0.00% <0.00%> (ø)
components/playground/instance/ticdc.go 0.00% <0.00%> (ø)
components/playground/instance/tiflash_config.go 100.00% <ø> (ø)
pkg/base52/base52.go 87.50% <ø> (ø)
pkg/checkpoint/checkpoint.go 82.79% <ø> (ø)
pkg/checkpoint/field.go 100.00% <ø> (ø)
... and 665 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7031e03...8b0ec4b. Read the comment docs.

Copy link
Member

@lucklove lucklove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 12, 2021
@AstroProfundis
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6046827

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 13, 2021
@ti-chi-bot ti-chi-bot merged commit 35998e0 into pingcap:master Jul 14, 2021
@AstroProfundis AstroProfundis deleted the issue-1449 branch July 14, 2021 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SELinux check formatting error
4 participants