-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix telemetry timeout #1500
Fix telemetry timeout #1500
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #1500 +/- ##
===========================================
+ Coverage 26.16% 56.13% +29.96%
===========================================
Files 267 292 +25
Lines 23926 26072 +2146
===========================================
+ Hits 6261 14635 +8374
+ Misses 16842 9428 -7414
- Partials 823 2009 +1186
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 236a92a
|
What problem does this PR solve?
The timeout setting (hard coded 2s) was not taking affect. It was introduced in #1327
What is changed and how it works?
local_install.sh
as offline installations does not need telemetry at all (they typically don't have access to the Internet)HTTPClient
inutils
to handle timeout correctly.Check List
Tests
Code changes
Related changes
Release notes: