Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: skip updating topology when reload with --skip-restart #1513

Merged
merged 1 commit into from
Aug 10, 2021

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

Fix #1507

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Related changes

  • Need to cherry-pick to the release branch

Release notes:

NONE

@AstroProfundis AstroProfundis added type/bug-fix Categorizes PR as a bug-fix component/cluster Issues about the tiup-cluster component labels Aug 10, 2021
@AstroProfundis AstroProfundis added this to the v1.5.5 milestone Aug 10, 2021
@AstroProfundis AstroProfundis self-assigned this Aug 10, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 10, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 10, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2021

Codecov Report

Merging #1513 (7971e74) into master (9a1ad59) will increase coverage by 24.76%.
The diff coverage is 25.00%.

❗ Current head 7971e74 differs from pull request most recent head 9ff0f19. Consider uploading reports for the commit 9ff0f19 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1513       +/-   ##
===========================================
+ Coverage   26.18%   50.95%   +24.76%     
===========================================
  Files         267      292       +25     
  Lines       23942    26075     +2133     
===========================================
+ Hits         6270    13286     +7016     
+ Misses      16849    10967     -5882     
- Partials      823     1822      +999     
Flag Coverage Δ
cluster 35.41% <0.00%> (?)
dm 26.31% <25.00%> (?)
integrate 45.35% <25.00%> (+29.23%) ⬆️
playground 13.79% <ø> (?)
tiup 16.11% <ø> (ø)
unittest 22.72% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/manager/reload.go 62.16% <25.00%> (+62.16%) ⬆️
components/playground/instance/pump.go 0.00% <0.00%> (ø)
...onents/playground/instance/tiflash_proxy_config.go 83.33% <0.00%> (ø)
components/playground/instance/instance.go 51.72% <0.00%> (ø)
pkg/logger/debug.go 20.00% <0.00%> (ø)
pkg/logger/logger.go 100.00% <0.00%> (ø)
pkg/cluster/operation/check.go 0.00% <0.00%> (ø)
pkg/cluster/operation/systemd.go 0.00% <0.00%> (ø)
components/playground/instance/tikv_config.go 100.00% <0.00%> (ø)
components/playground/instance/tikv.go 67.85% <0.00%> (ø)
... and 188 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a1ad59...9ff0f19. Read the comment docs.

Copy link
Member

@lucklove lucklove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 10, 2021
@AstroProfundis
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9ff0f19

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 10, 2021
@ti-chi-bot ti-chi-bot merged commit 8195da3 into pingcap:master Aug 10, 2021
@AstroProfundis AstroProfundis deleted the issue-1507 branch August 10, 2021 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/cluster Issues about the tiup-cluster component size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bug-fix Categorizes PR as a bug-fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to update configuration when the cluster is stopped
4 participants