Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove network request before enter component #1539

Merged
merged 9 commits into from
Sep 1, 2021

Conversation

nexustar
Copy link
Collaborator

What problem does this PR solve?

cant run component after remove tiup mirror

What is changed and how it works?

remove network request before exec component

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 30, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 30, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2021

Codecov Report

Merging #1539 (fa6e83c) into master (8c306ce) will increase coverage by 20.91%.
The diff coverage is 21.62%.

❗ Current head fa6e83c differs from pull request most recent head 64d813b. Consider uploading reports for the commit 64d813b to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1539       +/-   ##
===========================================
+ Coverage   26.27%   47.18%   +20.91%     
===========================================
  Files         267      277       +10     
  Lines       24069    24775      +706     
===========================================
+ Hits         6323    11690     +5367     
+ Misses      16924    11353     -5571     
- Partials      822     1732      +910     
Flag Coverage Δ
cluster 43.40% <0.00%> (?)
dm 26.24% <0.00%> (?)
integrate 47.18% <21.62%> (+31.09%) ⬆️
playground 13.83% <21.62%> (?)
tiup ?
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/exec/run.go 20.93% <0.00%> (-35.60%) ⬇️
pkg/repository/v1_repository.go 44.88% <31.25%> (-16.28%) ⬇️
pkg/environment/env.go 41.48% <31.57%> (-18.10%) ⬇️
pkg/utils/regexp.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/repository/store/store.go 0.00% <0.00%> (-100.00%) ⬇️
components/dm/ansible/worker.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/telemetry/telemetry.go 0.00% <0.00%> (-83.34%) ⬇️
pkg/repository/utils/hash.go 0.00% <0.00%> (-83.34%) ⬇️
pkg/repository/model/publish.go 0.00% <0.00%> (-83.34%) ⬇️
pkg/repository/store/local.go 0.00% <0.00%> (-82.61%) ⬇️
... and 262 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c306ce...64d813b. Read the comment docs.

Copy link
Contributor

@AstroProfundis AstroProfundis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 31, 2021
@AstroProfundis AstroProfundis added this to the v1.6.0 milestone Aug 31, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 64d813b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 1, 2021
@ti-chi-bot ti-chi-bot merged commit 9fad5c7 into pingcap:master Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants