-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove network request before enter component #1539
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #1539 +/- ##
===========================================
+ Coverage 26.27% 47.18% +20.91%
===========================================
Files 267 277 +10
Lines 24069 24775 +706
===========================================
+ Hits 6323 11690 +5367
+ Misses 16924 11353 -5571
- Partials 822 1732 +910
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 64d813b
|
What problem does this PR solve?
cant run component after remove tiup mirror
What is changed and how it works?
remove network request before exec component
Check List
Tests
Code changes
Side effects
Related changes
Release notes: