Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Dumpling/Lightning compatibility #1569

Merged
merged 1 commit into from
Oct 8, 2021

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Sep 30, 2021

What problem does this PR solve?

When executing tiup <component> -- <options> this removes the -- from being passed down to the command that's called.

What is changed and how it works?

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Related changes

  • Need to cherry-pick to the release branch

Release notes:

Using `--` to separate arguments for tiup and the component being called is no longer passed down to the component

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 30, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 30, 2021
@dveeden
Copy link
Contributor Author

dveeden commented Sep 30, 2021

/cc @AstroProfundis

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2021

Codecov Report

Merging #1569 (9bc475b) into master (a9a260a) will increase coverage by 4.61%.
The diff coverage is 0.00%.

❗ Current head 9bc475b differs from pull request most recent head 77c9fbc. Consider uploading reports for the commit 77c9fbc to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1569      +/-   ##
==========================================
+ Coverage   26.19%   30.80%   +4.61%     
==========================================
  Files         266      278      +12     
  Lines       24050    24549     +499     
==========================================
+ Hits         6300     7563    +1263     
+ Misses      16928    15991     -937     
- Partials      822      995     +173     
Flag Coverage Δ
integrate 21.69% <0.00%> (+5.89%) ⬆️
playground 13.53% <0.00%> (?)
tiup 15.80% <0.00%> (-0.01%) ⬇️
unittest 22.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/exec/run.go 59.53% <0.00%> (+0.71%) ⬆️
...onents/playground/instance/tiflash_proxy_config.go 83.33% <0.00%> (ø)
components/playground/instance/tikv.go 67.85% <0.00%> (ø)
components/playground/instance/ticdc.go 0.00% <0.00%> (ø)
components/playground/instance/tikv_config.go 100.00% <0.00%> (ø)
components/playground/instance/pump.go 0.00% <0.00%> (ø)
components/playground/instance/drainer.go 0.00% <0.00%> (ø)
components/playground/instance/pd.go 75.00% <0.00%> (ø)
components/playground/instance/tiflash_config.go 100.00% <0.00%> (ø)
components/playground/instance/instance.go 51.72% <0.00%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9a260a...77c9fbc. Read the comment docs.

@dveeden
Copy link
Contributor Author

dveeden commented Sep 30, 2021

/uncc @nrc
/cc @lucklove

@ti-chi-bot ti-chi-bot requested review from lucklove and removed request for nrc September 30, 2021 11:19
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 8, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 77c9fbc

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 8, 2021
@ti-chi-bot ti-chi-bot merged commit fadb027 into pingcap:master Oct 8, 2021
@AstroProfundis AstroProfundis added this to the v1.6.0 milestone Oct 8, 2021
@AstroProfundis AstroProfundis added the component/tiup Issues about the TiUP package management component itself label Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/tiup Issues about the TiUP package management component itself size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants