-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Dumpling/Lightning compatibility #1569
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/cc @AstroProfundis |
Codecov Report
@@ Coverage Diff @@
## master #1569 +/- ##
==========================================
+ Coverage 26.19% 30.80% +4.61%
==========================================
Files 266 278 +12
Lines 24050 24549 +499
==========================================
+ Hits 6300 7563 +1263
+ Misses 16928 15991 -937
- Partials 822 995 +173
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 77c9fbc
|
What problem does this PR solve?
When executing
tiup <component> -- <options>
this removes the--
from being passed down to the command that's called.-h
and--host
don't behave the same dumpling#312What is changed and how it works?
Check List
Tests
Related changes
Release notes: