Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: add tls support when deploy and scale-out tiflash #1594

Merged
merged 4 commits into from
Oct 25, 2021

Conversation

nexustar
Copy link
Collaborator

What problem does this PR solve?

What is changed and how it works?

  • add tls support when deploy and scale-out tiflash

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 21, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 21, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2021

Codecov Report

Merging #1594 (53444cc) into master (b38df71) will increase coverage by 34.87%.
The diff coverage is 29.62%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1594       +/-   ##
===========================================
+ Coverage   15.80%   50.68%   +34.87%     
===========================================
  Files         149      290      +141     
  Lines       15023    26395    +11372     
===========================================
+ Hits         2375    13377    +11002     
+ Misses      12131    10999     -1132     
- Partials      517     2019     +1502     
Flag Coverage Δ
cluster 43.77% <29.62%> (?)
dm 26.12% <0.00%> (?)
integrate 50.68% <29.62%> (+34.87%) ⬆️
playground 13.50% <0.00%> (?)
tiup 15.74% <0.00%> (-0.06%) ⬇️
unittest ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/spec/validate.go 62.95% <ø> (+62.95%) ⬆️
pkg/cluster/spec/tiflash.go 50.81% <26.08%> (+50.81%) ⬆️
pkg/cluster/manager/deploy.go 72.33% <50.00%> (ø)
pkg/cluster/manager/scale_out.go 42.20% <50.00%> (ø)
pkg/repository/store/txn.go 49.66% <0.00%> (-2.02%) ⬇️
components/playground/instance/tiflash_config.go 100.00% <0.00%> (ø)
pkg/cluster/manager/list.go 82.85% <0.00%> (ø)
pkg/cluster/manager/exec.go 70.00% <0.00%> (ø)
components/dm/command/upgrade.go 81.81% <0.00%> (ø)
components/playground/instance/tikv.go 67.85% <0.00%> (ø)
... and 238 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b38df71...53444cc. Read the comment docs.

Copy link
Contributor

@AstroProfundis AstroProfundis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 21, 2021
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 25, 2021
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 25, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 53444cc

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 25, 2021
@ti-chi-bot ti-chi-bot merged commit e4b380e into pingcap:master Oct 25, 2021
@AstroProfundis AstroProfundis added this to the v1.7.0 milestone Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support deploy && scale-out TiFlash instance on a TLS-enabled cluster
4 participants