-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster: add tls support when deploy and scale-out tiflash #1594
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #1594 +/- ##
===========================================
+ Coverage 15.80% 50.68% +34.87%
===========================================
Files 149 290 +141
Lines 15023 26395 +11372
===========================================
+ Hits 2375 13377 +11002
+ Misses 12131 10999 -1132
- Partials 517 2019 +1502
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7a5a595
to
53444cc
Compare
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 53444cc
|
What problem does this PR solve?
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release notes: