Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: add ng-monitoring support #1601

Merged
merged 18 commits into from
Nov 11, 2021
Merged

Conversation

nexustar
Copy link
Collaborator

@nexustar nexustar commented Oct 27, 2021

What problem does this PR solve?

What is changed and how it works?

add ng-monitoring support, deploy it with prometheus

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 27, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 27, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2021

Codecov Report

Merging #1601 (ce7d050) into master (ab0e748) will increase coverage by 29.86%.
The diff coverage is 75.32%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1601       +/-   ##
===========================================
+ Coverage   15.71%   45.58%   +29.86%     
===========================================
  Files         149      291      +142     
  Lines       15097    26559    +11462     
===========================================
+ Hits         2372    12106     +9734     
- Misses      12208    12621      +413     
- Partials      517     1832     +1315     
Flag Coverage Δ
cluster 35.73% <75.32%> (?)
dm 26.18% <61.03%> (?)
integrate 45.58% <75.32%> (+29.86%) ⬆️
playground 13.41% <0.00%> (?)
tiup 15.63% <0.00%> (-0.08%) ⬇️
unittest ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/template/scripts/monitoring.go 68.00% <50.00%> (ø)
pkg/cluster/spec/validate.go 63.19% <66.66%> (+63.19%) ⬆️
pkg/cluster/spec/monitoring.go 77.31% <70.00%> (ø)
pkg/cluster/template/config/ngmonitoring.go 82.22% <82.22%> (ø)
components/dm/command/restart.go 83.33% <0.00%> (ø)
components/dm/command/start.go 83.33% <0.00%> (ø)
components/dm/ansible/import.go 0.00% <0.00%> (ø)
pkg/cluster/manager/upgrade.go 54.74% <0.00%> (ø)
pkg/cluster/task/install_package.go 44.44% <0.00%> (ø)
components/cluster/command/display.go 33.33% <0.00%> (ø)
... and 233 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab0e748...ce7d050. Read the comment docs.

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 28, 2021
@ti-chi-bot
Copy link
Member

@crazycs520: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 11, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4808415

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 11, 2021
@AstroProfundis
Copy link
Contributor

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2021
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Nov 11, 2021
@AstroProfundis
Copy link
Contributor

/unhold

/merge

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2021
@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ce7d050

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 11, 2021
@ti-chi-bot ti-chi-bot merged commit 01843be into pingcap:master Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy ng-monitoring-server in monitoring_servers
5 participants