-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster: add ng-monitoring support #1601
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #1601 +/- ##
===========================================
+ Coverage 15.71% 45.58% +29.86%
===========================================
Files 149 291 +142
Lines 15097 26559 +11462
===========================================
+ Hits 2372 12106 +9734
- Misses 12208 12621 +413
- Partials 517 1832 +1315
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Co-authored-by: crazycs <crazycs520@gmail.com>
@crazycs520: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 4808415
|
/hold |
/unhold /merge |
This pull request has been accepted and is ready to merge. Commit hash: ce7d050
|
What problem does this PR solve?
What is changed and how it works?
add ng-monitoring support, deploy it with prometheus
Check List
Tests
Code changes
Side effects
Related changes
Release notes: