Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playground: add data-dir to ticdc #1631

Merged
merged 2 commits into from
Nov 22, 2021

Conversation

nexustar
Copy link
Collaborator

@nexustar nexustar commented Nov 19, 2021

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 19, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 19, 2021
@nexustar nexustar removed the request for review from 9547 November 19, 2021 10:10
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 22, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a9dfbc6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 22, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2021

Codecov Report

Merging #1631 (7606deb) into master (6b1719c) will increase coverage by 5.84%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1631      +/-   ##
==========================================
+ Coverage   15.59%   21.43%   +5.84%     
==========================================
  Files         151      169      +18     
  Lines       15234    17142    +1908     
==========================================
+ Hits         2376     3675    +1299     
- Misses      12341    12767     +426     
- Partials      517      700     +183     
Flag Coverage Δ
integrate 21.43% <0.00%> (+5.84%) ⬆️
playground 13.35% <0.00%> (?)
tiup 15.59% <ø> (ø)
unittest ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/playground/instance/ticdc.go 0.00% <0.00%> (ø)
components/playground/instance/tiflash.go 61.98% <0.00%> (ø)
components/playground/instance/instance.go 51.72% <0.00%> (ø)
components/playground/instance/drainer.go 0.00% <0.00%> (ø)
components/playground/command.go 82.90% <0.00%> (ø)
components/playground/instance/process.go 84.90% <0.00%> (ø)
components/playground/instance/tidb.go 84.61% <0.00%> (ø)
...onents/playground/instance/tiflash_proxy_config.go 83.33% <0.00%> (ø)
components/playground/grafana.go 78.40% <0.00%> (ø)
components/playground/instance/tikv.go 67.85% <0.00%> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b1719c...7606deb. Read the comment docs.

@ti-chi-bot ti-chi-bot merged commit d4de166 into pingcap:master Nov 22, 2021
@nexustar nexustar added this to the v1.8.0 milestone Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bootstrap TiCDC servers with the TiUP's default data-dir configuration
4 participants