-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
playground: fix wrong flag name #1635
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #1635 +/- ##
=======================================
Coverage 15.59% 15.59%
=======================================
Files 151 151
Lines 15234 15234
=======================================
Hits 2376 2376
Misses 12341 12341
Partials 517 517
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
@zhangyangyu: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
@srstack: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: e461aa8
|
What problem does this PR solve?
playground db.host,db.port,pd.host changed to db.Host, db.Port and pd.Host, need to be restored
Close #1632
What is changed and how it works?
to
Check List
Tests
Code changes
Release notes: