Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playground: fix wrong flag name #1635

Merged
merged 2 commits into from
Nov 23, 2021
Merged

Conversation

srstack
Copy link
Collaborator

@srstack srstack commented Nov 22, 2021

What problem does this PR solve?

playground db.host,db.port,pd.host changed to db.Host, db.Port and pd.Host, need to be restored
Close #1632

What is changed and how it works?

image
to
rikQV83Fld

Check List

Tests

  • No code

Code changes

  • Has persistent data change

Release notes:

NONE

@srstack srstack added the component/playground Issues about the tiup-playground component label Nov 22, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 22, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@CLAassistant
Copy link

CLAassistant commented Nov 22, 2021

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 22, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #1635 (8c16c2b) into master (a713f26) will not change coverage.
The diff coverage is n/a.

❗ Current head 8c16c2b differs from pull request most recent head e461aa8. Consider uploading reports for the commit e461aa8 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1635   +/-   ##
=======================================
  Coverage   15.59%   15.59%           
=======================================
  Files         151      151           
  Lines       15234    15234           
=======================================
  Hits         2376     2376           
  Misses      12341    12341           
  Partials      517      517           
Flag Coverage Δ
integrate 15.59% <ø> (ø)
tiup 15.59% <ø> (ø)
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a713f26...e461aa8. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 22, 2021
@AstroProfundis AstroProfundis added this to the v1.7.1 milestone Nov 22, 2021
@nexustar nexustar changed the title Issue 1632 playground: fix wrong flag name Nov 22, 2021
@ti-chi-bot
Copy link
Member

@zhangyangyu: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@srstack
Copy link
Collaborator Author

srstack commented Nov 23, 2021

/merge

@ti-chi-bot
Copy link
Member

@srstack: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@nexustar
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e461aa8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 23, 2021
@ti-chi-bot ti-chi-bot merged commit ca94426 into pingcap:master Nov 23, 2021
@srstack srstack self-assigned this Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/playground Issues about the tiup-playground component size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

playground db.host,db.port,pd.host changed to db.Host, db.Port and pd.Host
7 participants