-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster: prohibit the clean operations during scale-out #1642
cluster: prohibit the clean operations during scale-out #1642
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #1642 +/- ##
===========================================
+ Coverage 15.55% 50.42% +34.87%
===========================================
Files 151 294 +143
Lines 15275 26914 +11639
===========================================
+ Hits 2376 13572 +11196
+ Misses 12382 11275 -1107
- Partials 517 2067 +1550
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 9277508
|
What problem does this PR solve?
prohibit the clean operations during scale-out
Because the clean operation will stop the cluster, if the cluster is stopped while the scale-out is not completed, the scale-out will be abnormal.
What is changed and how it works?
Will check the scale-out file lock before clean
Check List
Tests
Error: Scale-out file lock already exists (spec.scale-out lock) Verbose debug logs has been written to /home/tidb/.tiup/logs/tiup-cluster-debug-2021-11-29-12-06-08.log. Please run 'tiup-cluster scale-out --stage2' to continue.
Code changes
Side effects
Related changes
Release notes: