Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: No port conflicts were detected during scale-out of the cluster imported from ansible #1656

Merged
merged 2 commits into from
Dec 7, 2021

Conversation

srstack
Copy link
Collaborator

@srstack srstack commented Dec 7, 2021

What problem does this PR solve?

close #1655

What is changed and how it works?

delete skip nodes imported from TiDB-Ansible

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

Side effects

Related changes

Release notes:

NONE

@srstack srstack self-assigned this Dec 7, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 7, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 7, 2021
@srstack srstack changed the title Issue 1655 cluster: No port conflicts were detected during scale-out of the cluster imported from ansible Dec 7, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2021

Codecov Report

Merging #1656 (9cc9ffc) into master (f873e74) will increase coverage by 32.89%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1656       +/-   ##
===========================================
+ Coverage   15.68%   48.57%   +32.89%     
===========================================
  Files         152      296      +144     
  Lines       15349    27309    +11960     
===========================================
+ Hits         2407    13266    +10859     
+ Misses      12425    12019      -406     
- Partials      517     2024     +1507     
Flag Coverage Δ
cluster 42.90% <ø> (?)
dm 20.05% <ø> (?)
integrate 48.57% <ø> (+32.89%) ⬆️
playground 13.55% <ø> (?)
tiup 15.68% <ø> (+<0.01%) ⬆️
unittest ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/spec/validate.go 62.51% <ø> (+62.51%) ⬆️
components/cluster/command/display.go 58.13% <0.00%> (ø)
components/dm/command/restart.go 58.33% <0.00%> (ø)
components/cluster/command/root.go 46.25% <0.00%> (ø)
components/dm/command/patch.go 59.09% <0.00%> (ø)
components/cluster/main.go 100.00% <0.00%> (ø)
pkg/cluster/manager/list.go 67.39% <0.00%> (ø)
pkg/cluster/manager/show_config.go 0.00% <0.00%> (ø)
components/cluster/command/deploy.go 68.88% <0.00%> (ø)
pkg/cluster/task/shell.go 66.66% <0.00%> (ø)
... and 237 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f873e74...9cc9ffc. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 7, 2021
@AstroProfundis AstroProfundis added this to the v1.8.1 milestone Dec 7, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9cc9ffc

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 7, 2021
@ti-chi-bot ti-chi-bot merged commit 23c7bef into pingcap:master Dec 7, 2021
AstroProfundis pushed a commit that referenced this pull request Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No port conflicts were detected during scale-out of the cluster imported from ansible
4 participants