Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix slow ssh connect when using buildin ssh #1664

Merged
merged 1 commit into from
Dec 13, 2021

Conversation

nexustar
Copy link
Collaborator

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 10, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 10, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2021

Codecov Report

Merging #1664 (c9ed7d8) into master (23c7bef) will increase coverage by 34.92%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1664       +/-   ##
===========================================
+ Coverage   15.68%   50.60%   +34.92%     
===========================================
  Files         152      296      +144     
  Lines       15347    27309    +11962     
===========================================
+ Hits         2407    13821    +11414     
+ Misses      12423    11414     -1009     
- Partials      517     2074     +1557     
Flag Coverage Δ
cluster 43.98% <ø> (?)
dm 26.08% <ø> (?)
integrate 50.60% <ø> (+34.92%) ⬆️
playground 13.55% <ø> (?)
tiup 15.68% <ø> (ø)
unittest ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/operation/download.go 40.00% <0.00%> (ø)
components/dm/spec/bindversion.go 100.00% <0.00%> (ø)
components/cluster/command/exec.go 88.88% <0.00%> (ø)
pkg/cluster/task/update_meta.go 85.00% <0.00%> (ø)
pkg/cluster/task/step.go 67.88% <0.00%> (ø)
components/playground/instance/ticdc.go 0.00% <0.00%> (ø)
pkg/cluster/operation/operation.go 78.57% <0.00%> (ø)
pkg/cluster/manager/cacert.go 55.10% <0.00%> (ø)
components/dm/command/deploy.go 68.42% <0.00%> (ø)
pkg/cluster/manager/patch.go 48.80% <0.00%> (ø)
... and 237 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23c7bef...c9ed7d8. Read the comment docs.

Copy link
Collaborator

@srstack srstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ti-chi-bot
Copy link
Member

@srstack: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

/LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@nexustar nexustar added this to the v1.8.1 milestone Dec 10, 2021
@nexustar
Copy link
Collaborator Author

/merge

@ti-chi-bot
Copy link
Member

@nexustar: /merge in this pull request requires 1 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 13, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c9ed7d8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 13, 2021
@ti-chi-bot ti-chi-bot merged commit 0de8baf into pingcap:master Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants