Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: add configuration rendering for web listen-address #1669

Merged
merged 6 commits into from
Dec 15, 2021

Conversation

srstack
Copy link
Collaborator

@srstack srstack commented Dec 13, 2021

What problem does this PR solve?

cluster: add configuration rendering for web listen-address

What is changed and how it works?

fix pr #1665 , not rander web-listen-address

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

Related changes

Release notes:

NONE

@srstack srstack added the component/cluster Issues about the tiup-cluster component label Dec 13, 2021
@srstack srstack added this to the v1.9.0 milestone Dec 13, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 13, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@srstack srstack self-assigned this Dec 13, 2021
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 13, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2021

Codecov Report

Merging #1669 (45ea70e) into master (3f0c568) will increase coverage by 34.89%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1669       +/-   ##
===========================================
+ Coverage   15.77%   50.66%   +34.89%     
===========================================
  Files         152      296      +144     
  Lines       15261    27235    +11974     
===========================================
+ Hits         2407    13798    +11391     
+ Misses      12337    11377      -960     
- Partials      517     2060     +1543     
Flag Coverage Δ
cluster 43.86% <ø> (?)
dm 26.35% <ø> (?)
integrate 50.66% <ø> (+34.89%) ⬆️
playground 13.47% <ø> (?)
tiup 15.79% <ø> (+0.02%) ⬆️
unittest ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/dm/command/root.go 58.08% <0.00%> (ø)
components/dm/spec/cluster.go 90.90% <0.00%> (ø)
pkg/cluster/manager/deploy.go 73.28% <0.00%> (ø)
components/playground/grafana.go 78.40% <0.00%> (ø)
pkg/cluster/operation/systemd.go 75.00% <0.00%> (ø)
components/playground/instance/pump.go 0.00% <0.00%> (ø)
pkg/cluster/manager/edit_config.go 32.43% <0.00%> (ø)
components/playground/instance/tiflash.go 61.98% <0.00%> (ø)
components/dm/command/upgrade.go 81.81% <0.00%> (ø)
pkg/cluster/task/func.go 40.00% <0.00%> (ø)
... and 238 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f0c568...45ea70e. Read the comment docs.

@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 14, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2fd6269

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 14, 2021
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Dec 14, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 45ea70e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 14, 2021
@ti-chi-bot ti-chi-bot merged commit c164223 into pingcap:master Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/cluster Issues about the tiup-cluster component size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants