-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the config 'runAsDaemon' from tiflash.toml #1673
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #1673 +/- ##
===========================================
+ Coverage 14.82% 32.36% +17.55%
===========================================
Files 152 266 +114
Lines 18743 32057 +13314
===========================================
+ Hits 2777 10375 +7598
- Misses 15449 20212 +4763
- Partials 517 1470 +953
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/merge |
This pull request has been accepted and is ready to merge. Commit hash: ae3b6b6
|
What problem does this PR solve?
#1671
What is changed and how it works?
Check the TiFlash version, remove the runAsDaemon config if TiFlash is in new version(>=v5.4.0) or the nightly version.
Check List
Tests
Release notes: