-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tiup/mirror: add ability to change owner of a component #1676
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #1676 +/- ##
===========================================
+ Coverage 14.81% 32.41% +17.60%
===========================================
Files 152 247 +95
Lines 18751 28842 +10091
===========================================
+ Hits 2777 9347 +6570
- Misses 15457 18179 +2722
- Partials 517 1316 +799
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: d88c403
|
What problem does this PR solve?
Change the owner of a component.
What is changed and how it works?
Use a process like rotating
root.json
:tiup mirror transfer-owner
command to initialize a owner transfer processcomponent.json
tiup mirror sign
to sign that temp URLcomponent.json
along withindex.json
The process is a pure administration operation, and could be used without the participate of old owner of the component, so that it also works if the old owner is absent for long time and can not be contacted.
The new owner must be granted before the transfer.
Check List
Tests
Code changes
Release notes: