cluster: fix wrong default initial-commit-ts in drainer

[nexustar]

What problem does this PR solve?

close #1677 #1680

What is changed and how it works?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Code changes

• Has exported function/method change
• Has exported variable/fields change
• Has interface methods change
• Has persistent data change

Side effects

• Possible performance regression
• Increased code complexity
• Breaking backward compatibility

Related changes

• Need to cherry-pick to the release branch
• Need to update the documentation

Release notes:

NONE

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[codecov-commenter]

Codecov Report

Merging #1678 (949efc6) into master (60ae371) will decrease coverage by 3.02%.
The diff coverage is n/a.

❗ Current head 949efc6 differs from pull request most recent head 7c91213. Consider uploading reports for the commit 7c91213 to get more accurate results

@@            Coverage Diff             @@
##           master    #1678      +/-   ##
==========================================
- Coverage   42.83%   39.81%   -3.02%     
==========================================
  Files         298      298              
  Lines       33525    33525              
==========================================
- Hits        14359    13347    -1012     
- Misses      17284    18395    +1111     
+ Partials     1882     1783      -99     

Flag	Coverage Δ
cluster	29.23% <ø> (-4.13%)	⬇️
unittest	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/cluster/spec/drainer.go	55.28% <ø> (ø)
pkg/cluster/template/config/config.go	0.00% <0.00%> (-100.00%)	⬇️
pkg/cluster/template/scripts/scripts.go	0.00% <0.00%> (-100.00%)	⬇️
pkg/cluster/template/scripts/tiflash.go	0.00% <0.00%> (-77.94%)	⬇️
pkg/cluster/template/systemd/tispark.go	0.00% <0.00%> (-65.71%)	⬇️
pkg/cluster/template/scripts/tispark.go	0.00% <0.00%> (-63.79%)	⬇️
pkg/cluster/template/config/tispark.go	0.00% <0.00%> (-61.29%)	⬇️
pkg/cluster/spec/tispark.go	2.29% <0.00%> (-59.92%)	⬇️
pkg/cluster/spec/tiflash.go	0.89% <0.00%> (-46.33%)	⬇️
pkg/cluster/spec/bindversion.go	54.55% <0.00%> (-36.36%)	⬇️
... and 35 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60ae371...7c91213. Read the comment docs.

[srstack]

/LGTM

[glkappe]

https://github.com/pingcap/tidb-binlog/blob/53a591e8258a97aefe9f5b705176e4a9d068c59e/arbiter/config.go#L66

In drainer's code, --initial-commit-ts may be of type int?

[nexustar]

https://github.com/pingcap/tidb-binlog/blob/53a591e8258a97aefe9f5b705176e4a9d068c59e/arbiter/config.go#L66

In drainer's code, --initial-commit-ts may be of type int?

Type of DrainerSpec.CommitTS is only used inside tiup-cluster, it is the same after yaml.Marshal()
if it need to be int, we should modify template of run_drainer.sh

[AstroProfundis]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 7c91213