Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dm: add new config to dm template #1692

Merged
merged 2 commits into from
Dec 28, 2021
Merged

Conversation

lance6716
Copy link
Contributor

What problem does this PR solve?

include new config to tiup dm template --full

What is changed and how it works?

Check List

Tests

  • No code

Code changes

Side effects

Related changes

  • Need to update the documentation

Release notes:

Add new configuration to `tiup dm template --full` 

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 23, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@CLAassistant
Copy link

CLAassistant commented Dec 23, 2021

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 23, 2021
@lance6716
Copy link
Contributor Author

ptal @sunzhaoyang

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2021

Codecov Report

Merging #1692 (745778e) into master (c925128) will decrease coverage by 0.61%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1692      +/-   ##
==========================================
- Coverage   47.88%   47.27%   -0.61%     
==========================================
  Files         301      301              
  Lines       34001    34001              
==========================================
- Hits        16280    16073     -207     
- Misses      15608    15812     +204     
- Partials     2113     2116       +3     
Flag Coverage Δ
cluster 40.72% <ø> (-0.77%) ⬇️
dm 24.80% <ø> (-0.05%) ⬇️
playground 12.78% <ø> (ø)
tiup 14.66% <ø> (ø)
unittest ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/operation/scale_in.go 40.17% <0.00%> (-14.96%) ⬇️
pkg/cluster/api/pdapi.go 48.50% <0.00%> (-12.57%) ⬇️
pkg/cluster/task/init_config.go 40.91% <0.00%> (-9.09%) ⬇️
pkg/cluster/task/update_meta.go 78.49% <0.00%> (-8.60%) ⬇️
pkg/cluster/task/task.go 64.81% <0.00%> (-8.33%) ⬇️
pkg/cluster/spec/parse_topology.go 72.83% <0.00%> (-7.61%) ⬇️
pkg/tui/cliutil.go 63.95% <0.00%> (-6.98%) ⬇️
pkg/cluster/task/step.go 64.94% <0.00%> (-3.90%) ⬇️
pkg/cluster/manager/destroy.go 56.25% <0.00%> (-3.57%) ⬇️
pkg/tui/progress/single_bar.go 84.78% <0.00%> (-3.26%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c925128...745778e. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 28, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b527cd6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 28, 2021
@ti-chi-bot
Copy link
Member

@lance6716: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit b787203 into pingcap:master Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants