Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TiUP: update --self add some checks. #1695

Merged
merged 8 commits into from
Dec 28, 2021
Merged

Conversation

srstack
Copy link
Collaborator

@srstack srstack commented Dec 23, 2021

What problem does this PR solve?

close #1693

What is changed and how it works?

tiup update --self
Backup of `/Users/srstack/.tiup/bin/tiup` to `/Users/srstack/.tiup/bin/tiup.tmp` failed.
Error: rename /Users/srstack/.tiup/bin/tiup /Users/srstack/.tiup/bin/tiup.tmp: no such file or directory

to

tiup update --self
Tiup install directory is: /opt/homebrew/Cellar/tiup/v1.8.1/bin
Error: If you used some external package manager to install TiUP (e.g., brew), try upgrade with that

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

Side effects

Related changes

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 23, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nexustar

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@srstack srstack requested review from AstroProfundis and nexustar and removed request for lonng and birdstorm December 23, 2021 11:00
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 23, 2021
@srstack srstack self-assigned this Dec 23, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2021

Codecov Report

Merging #1695 (08d2aaf) into master (be07156) will decrease coverage by 5.68%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1695      +/-   ##
==========================================
- Coverage   47.88%   42.21%   -5.68%     
==========================================
  Files         301      301              
  Lines       33993    34011      +18     
==========================================
- Hits        16277    14355    -1922     
- Misses      15603    17741    +2138     
+ Partials     2113     1915     -198     
Flag Coverage Δ
cluster 32.71% <ø> (-8.78%) ⬇️
dm 24.80% <ø> (-0.05%) ⬇️
playground 12.78% <ø> (ø)
tiup 14.66% <0.00%> (+0.01%) ⬆️
unittest ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/update.go 37.80% <0.00%> (-10.63%) ⬇️
pkg/cluster/operation/systemd.go 0.00% <0.00%> (-75.00%) ⬇️
pkg/cluster/manager/check.go 0.00% <0.00%> (-69.81%) ⬇️
pkg/cluster/task/limits.go 0.00% <0.00%> (-65.22%) ⬇️
pkg/cluster/task/sysctl.go 0.00% <0.00%> (-63.64%) ⬇️
pkg/cluster/manager/cleanup.go 0.00% <0.00%> (-57.92%) ⬇️
pkg/cluster/template/config/alertmanager.go 0.00% <0.00%> (-55.00%) ⬇️
pkg/cluster/task/copy_file.go 0.00% <0.00%> (-52.94%) ⬇️
pkg/cluster/operation/check.go 0.00% <0.00%> (-50.46%) ⬇️
pkg/cluster/task/rmdir.go 0.00% <0.00%> (-46.67%) ⬇️
... and 75 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be07156...08d2aaf. Read the comment docs.

@srstack srstack changed the title TiUP: update --self add some judgments. TiUP: update --self add some checks. Dec 23, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 28, 2021
@AstroProfundis
Copy link
Contributor

I think it's better to say "If you used some external package manager to install TiUP (e.g., brew), try upgrade with that." as brew is not the only way a user may get TiUP without our script.

@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 28, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 08d2aaf

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 28, 2021
@ti-chi-bot ti-chi-bot merged commit 26e5521 into pingcap:master Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tiup: update --self need to add some judgments.
5 participants