-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster: support init root password #1700
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Is it available for TLS-enabled cluster? |
a73b6be
to
3e9e141
Compare
Codecov Report
@@ Coverage Diff @@
## master #1700 +/- ##
==========================================
+ Coverage 47.33% 53.19% +5.86%
==========================================
Files 301 303 +2
Lines 34011 34096 +85
==========================================
+ Hits 16098 18135 +2037
+ Misses 15797 13827 -1970
- Partials 2116 2134 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Yes, as we don't support TLS encrypted MySQL client yet, the protocol between client and TiDB server is identical with those TLS disabled. |
TLS-enabled means to enable TLS encrypted communication between TiDB components, but does not include the communication between MySQL Client and TiDB. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
@srstack: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 3e9e141
|
What problem does this PR solve?
Close #1660
What is changed and how it works?
An
--init
argument is added totiup-cluster start
subcommand, it generates a 18 chars long random password and set it to theroot@'%'
user.Check List
Tests
Related changes
Release notes: