-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
not record "tiup __complete" in telemetry and audit log #1717
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #1717 +/- ##
==========================================
- Coverage 53.26% 53.24% -0.02%
==========================================
Files 303 303
Lines 34267 34270 +3
==========================================
- Hits 18250 18246 -4
- Misses 13875 13880 +5
- Partials 2142 2144 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/merge Does this PR need to be added to v1.8.x? |
This pull request has been accepted and is ready to merge. Commit hash: 0c94f22
|
not necessary, as we do not have a usable auto-completion on v1.8.x |
What problem does this PR solve?
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release notes: