Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: fix malformed commands in local executor #1734

Merged
merged 3 commits into from
Feb 7, 2022

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

Fix #1268

What is changed and how it works?

Adjust commands to use ' for sed instead of " and properly escape " in commands.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release notes:

NONE

@AstroProfundis AstroProfundis added this to the v1.9.0 milestone Jan 20, 2022
@AstroProfundis AstroProfundis self-assigned this Jan 20, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 20, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • srstack

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 20, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2022

Codecov Report

Merging #1734 (4836a9b) into master (44ceb86) will decrease coverage by 0.04%.
The diff coverage is 78.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1734      +/-   ##
==========================================
- Coverage   53.21%   53.17%   -0.04%     
==========================================
  Files         303      303              
  Lines       34357    34363       +6     
==========================================
- Hits        18282    18272      -10     
- Misses      13933    13945      +12     
- Partials     2142     2146       +4     
Flag Coverage Δ
cluster 41.39% <39.13%> (-0.04%) ⬇️
dm 24.77% <43.48%> (-0.01%) ⬇️
playground 12.73% <0.00%> (-<0.01%) ⬇️
tiup 14.52% <0.00%> (-0.03%) ⬇️
unittest 21.42% <47.83%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/executor/local.go 59.38% <61.54%> (-0.62%) ⬇️
pkg/cluster/spec/grafana.go 63.81% <100.00%> (ø)
pkg/cluster/spec/monitoring.go 72.73% <100.00%> (ø)
pkg/repository/store/txn.go 56.91% <0.00%> (-2.13%) ⬇️
pkg/cluster/api/pdapi.go 59.47% <0.00%> (-1.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44ceb86...4836a9b. Read the comment docs.

pkg/cluster/executor/local.go Show resolved Hide resolved
pkg/cluster/executor/local.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 27, 2022
@AstroProfundis
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4836a9b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 7, 2022
@ti-chi-bot ti-chi-bot merged commit 4e76743 into pingcap:master Feb 7, 2022
@AstroProfundis AstroProfundis deleted the local-exec branch March 17, 2022 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tiup cluster with --ssh none failed on malformed command(nested single quote)
4 participants