Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Amazon Linux 2 as supported OS #1740

Merged
merged 2 commits into from
Jan 26, 2022
Merged

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Jan 25, 2022

What problem does this PR solve?

Mark Amazon Linux 2 as supported

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release notes:

Amazon Linux is no longer marked as unsupported
$ cat /etc/os-release 
NAME="Amazon Linux"
VERSION="2"
ID="amzn"
ID_LIKE="centos rhel fedora"
VERSION_ID="2"
PRETTY_NAME="Amazon Linux 2"
ANSI_COLOR="0;33"
CPE_NAME="cpe:2.3:o:amazon:amazon_linux:2"
HOME_URL="https://amazonlinux.com/"
$ rpm -E %{rhel}
7
ip-**********.eu-central-1.compute.internal  os-version    Fail    os vendor amzn not supported

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 25, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 25, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2022

Codecov Report

Merging #1740 (dbde5d3) into master (4486823) will increase coverage by 21.50%.
The diff coverage is 0.00%.

❗ Current head dbde5d3 differs from pull request most recent head bbfe9c0. Consider uploading reports for the commit bbfe9c0 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1740       +/-   ##
===========================================
+ Coverage   24.42%   45.92%   +21.50%     
===========================================
  Files         277      303       +26     
  Lines       31461    34324     +2863     
===========================================
+ Hits         7682    15761     +8079     
+ Misses      22926    16689     -6237     
- Partials      853     1874     +1021     
Flag Coverage Δ
cluster 29.66% <0.00%> (?)
dm 24.79% <0.00%> (?)
playground 12.73% <ø> (?)
tiup 14.53% <ø> (ø)
unittest 21.34% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/operation/check.go 0.00% <0.00%> (ø)
components/playground/instance/drainer.go 0.00% <0.00%> (ø)
components/playground/instance/tiflash_config.go 70.59% <0.00%> (ø)
pkg/logger/logger.go 100.00% <0.00%> (ø)
components/playground/instance/tikv_config.go 100.00% <0.00%> (ø)
components/dm/task/update_dm_meta.go 87.76% <0.00%> (ø)
components/playground/instance/ticdc.go 0.00% <0.00%> (ø)
pkg/cluster/operation/pd_member.go 0.00% <0.00%> (ø)
components/playground/instance/process.go 81.97% <0.00%> (ø)
pkg/cluster/operation/action.go 63.66% <0.00%> (ø)
... and 185 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4486823...bbfe9c0. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 26, 2022
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: bbfe9c0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 26, 2022
@AstroProfundis AstroProfundis added this to the v1.9.0 milestone Jan 26, 2022
@ti-chi-bot ti-chi-bot merged commit d2e2b40 into pingcap:master Jan 26, 2022
@yahonda
Copy link
Member

yahonda commented Jan 27, 2022

Do we need to update https://docs.pingcap.com/tidb/stable/hardware-and-software-requirements to mention that 'Amazon Linux 2' is supported once the newer version of tiup released?

@dveeden
Copy link
Contributor Author

dveeden commented Jan 27, 2022

Do we need to update https://docs.pingcap.com/tidb/stable/hardware-and-software-requirements to mention that 'Amazon Linux 2' is supported once the newer version of tiup released?

Yes: pingcap/docs#7473

@yahonda
Copy link
Member

yahonda commented Jan 27, 2022

Thanks. I was not aware of that pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants