Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bench: update cmd flags of go-tpc v1.0.8 #1755

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

nexustar
Copy link
Collaborator

@nexustar nexustar commented Feb 14, 2022

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@nexustar nexustar added this to the v1.9.1 milestone Feb 14, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 14, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • srstack

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 14, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2022

Codecov Report

Merging #1755 (a727999) into master (382d0e9) will not change coverage.
The diff coverage is n/a.

❗ Current head a727999 differs from pull request most recent head e044c5e. Consider uploading reports for the commit e044c5e to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1755   +/-   ##
=======================================
  Coverage   53.15%   53.15%           
=======================================
  Files         303      303           
  Lines       34401    34401           
=======================================
  Hits        18284    18284           
  Misses      13972    13972           
  Partials     2145     2145           
Flag Coverage Δ
tiup 14.40% <ø> (ø)
unittest 21.34% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 382d0e9...e044c5e. Read the comment docs.

@nexustar nexustar changed the title bench: update cmd flags bench: update cmd flags of go-tpc v1.0.8 Feb 14, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 14, 2022
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e044c5e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 15, 2022
@ti-chi-bot ti-chi-bot merged commit f6f5c7b into pingcap:master Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Encounter "panic: Unknown partition type 0" when running tiup bench tpcc
5 participants