Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: fix upgrade not restart exporer #1758

Merged
merged 4 commits into from
Feb 21, 2022
Merged

Conversation

srstack
Copy link
Collaborator

@srstack srstack commented Feb 15, 2022

What problem does this PR solve?

close #1757

What is changed and how it works?

fix upgrade not restart exporer

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release notes:

NONE

@srstack srstack added this to the v1.9.1 milestone Feb 15, 2022
@srstack srstack self-assigned this Feb 15, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 15, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nexustar

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 15, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2022

Codecov Report

Merging #1758 (ee480cd) into master (382d0e9) will decrease coverage by 5.79%.
The diff coverage is 77.19%.

❗ Current head ee480cd differs from pull request most recent head e261e25. Consider uploading reports for the commit e261e25 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1758      +/-   ##
==========================================
- Coverage   53.15%   47.36%   -5.79%     
==========================================
  Files         303      302       -1     
  Lines       34401    34851     +450     
==========================================
- Hits        18284    16505    -1779     
- Misses      13972    16191    +2219     
- Partials     2145     2155      +10     
Flag Coverage Δ
dm 24.75% <54.64%> (-0.06%) ⬇️
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/ansible/inventory.go 0.00% <0.00%> (-57.00%) ⬇️
pkg/cluster/manager/builder.go 70.09% <ø> (-1.85%) ⬇️
pkg/cluster/manager/check.go 68.31% <0.00%> (ø)
pkg/cluster/manager/scale_out.go 37.24% <0.00%> (-4.08%) ⬇️
pkg/cluster/manager/deploy.go 78.18% <50.00%> (+10.74%) ⬆️
pkg/cluster/operation/upgrade.go 51.01% <61.54%> (-3.71%) ⬇️
pkg/cluster/spec/spec.go 63.59% <80.95%> (-19.23%) ⬇️
pkg/cluster/manager/manager.go 77.59% <91.38%> (+3.59%) ⬆️
components/cluster/command/check.go 75.56% <100.00%> (ø)
components/dm/spec/topology_dm.go 75.79% <100.00%> (-9.31%) ⬇️
... and 74 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 382d0e9...e261e25. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 17, 2022
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c96efa7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 21, 2022
@ti-chi-bot ti-chi-bot merged commit dc4f2d3 into pingcap:master Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cluster: after upgrade op exporer not restart
5 participants