-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster: add ngm metrics to promtheus config #1806
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #1806 +/- ##
==========================================
- Coverage 53.07% 47.02% -6.04%
==========================================
Files 303 287 -16
Lines 34644 33776 -868
==========================================
- Hits 18385 15883 -2502
- Misses 14099 16106 +2007
+ Partials 2160 1787 -373
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@crazycs520: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
pkg/cluster/spec/monitoring.go
Outdated
for i := 0; i < servers.Len(); i++ { | ||
monitoring := servers.Index(i).Interface().(*PrometheusSpec) | ||
uniqueHosts.Insert(monitoring.Host) | ||
cfig.AddNGMonitoring(monitoring.Host, uint64(monitoring.NgPort)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What will happen if there is no ngm instance available in the cluster?
return c | ||
} | ||
|
||
// AddGrafana add an kafka exporter address | ||
// AddGrafana add an Grafana exporter address |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// AddGrafana add an Grafana exporter address | |
// AddGrafana add an Grafana address |
/merge |
What problem does this PR solve?
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release notes: