Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiup: supprot record tiup execution history #1808

Merged

Conversation

srstack
Copy link
Collaborator

@srstack srstack commented Mar 23, 2022

What problem does this PR solve?

close #1793
supprot record tiup execution history

What is changed and how it works?

image

image

image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@srstack srstack added this to the v1.10.0 milestone Mar 23, 2022
@srstack srstack self-assigned this Mar 23, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 23, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 23, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2022

Codecov Report

Merging #1808 (c0614bb) into master (0c90f84) will decrease coverage by 10.02%.
The diff coverage is 3.47%.

❗ Current head c0614bb differs from pull request most recent head 3849347. Consider uploading reports for the commit 3849347 to get more accurate results

@@             Coverage Diff             @@
##           master    #1808       +/-   ##
===========================================
- Coverage   52.82%   42.79%   -10.02%     
===========================================
  Files         305      305               
  Lines       34868    34995      +127     
===========================================
- Hits        18417    14976     -3441     
- Misses      14296    18035     +3739     
+ Partials     2155     1984      -171     
Flag Coverage Δ
cluster 34.74% <0.00%> (-6.35%) ⬇️
dm 24.22% <0.00%> (-0.49%) ⬇️
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/environment/history.go 0.00% <0.00%> (ø)
cmd/root.go 61.54% <83.33%> (ø)
components/dm/ansible/worker.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/meta/err.go 0.00% <0.00%> (-76.19%) ⬇️
pkg/cluster/api/error.go 0.00% <0.00%> (-75.00%) ⬇️
pkg/crypto/rand/passwd.go 0.00% <0.00%> (-75.00%) ⬇️
pkg/cluster/operation/systemd.go 0.00% <0.00%> (-75.00%) ⬇️
pkg/telemetry/node_info.go 0.00% <0.00%> (-70.73%) ⬇️
pkg/cluster/manager/check.go 0.67% <0.00%> (-68.12%) ⬇️
pkg/cluster/task/limits.go 0.00% <0.00%> (-65.22%) ⬇️
... and 101 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c90f84...3849347. Read the comment docs.

@srstack srstack changed the title Tiup: supprot record tiup execution history tiup: supprot record tiup execution history Mar 23, 2022
pkg/environment/history.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 13, 2022
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3849347

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 18, 2022
@ti-chi-bot ti-chi-bot merged commit 6e8d6e2 into pingcap:master Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TiUP add audit log for ctl command
4 participants