Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add altermanager config #1818

Merged
merged 3 commits into from
Apr 18, 2022
Merged

add altermanager config #1818

merged 3 commits into from
Apr 18, 2022

Conversation

glkappe
Copy link
Contributor

@glkappe glkappe commented Mar 25, 2022

add alertmanager config

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

add alertmanager config
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 25, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 25, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2022

Codecov Report

Merging #1818 (f909413) into master (e475745) will increase coverage by 27.99%.
The diff coverage is n/a.

❗ Current head f909413 differs from pull request most recent head 9ea7b9b. Consider uploading reports for the commit 9ea7b9b to get more accurate results

@@             Coverage Diff             @@
##           master    #1818       +/-   ##
===========================================
+ Coverage   24.16%   52.15%   +27.99%     
===========================================
  Files         280      306       +26     
  Lines       32084    34975     +2891     
===========================================
+ Hits         7750    18238    +10488     
+ Misses      23465    14576     -8889     
- Partials      869     2161     +1292     
Flag Coverage Δ
cluster 40.29% <ø> (?)
dm 24.54% <ø> (?)
playground 12.79% <ø> (?)
tiup 14.44% <ø> (+0.29%) ⬆️
unittest 21.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/playground/instance/process.go 92.31% <0.00%> (ø)
pkg/logger/debug.go 16.67% <0.00%> (ø)
components/playground/instance/tiflash_config.go 72.22% <0.00%> (ø)
pkg/cluster/operation/check.go 48.51% <0.00%> (ø)
pkg/cluster/operation/telemetry.go 0.00% <0.00%> (ø)
components/playground/instance/pump.go 0.00% <0.00%> (ø)
components/playground/instance/tidb.go 81.25% <0.00%> (ø)
pkg/cluster/operation/pd_member.go 0.00% <0.00%> (ø)
pkg/cluster/operation/upgrade.go 55.88% <0.00%> (ø)
components/playground/instance/drainer.go 0.00% <0.00%> (ø)
... and 215 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e475745...9ea7b9b. Read the comment docs.

AstroProfundis and others added 2 commits April 18, 2022 12:09
Co-authored-by: Qiμ$hiЯuí <39378935+srstack@users.noreply.github.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 18, 2022
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9ea7b9b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 18, 2022
@ti-chi-bot ti-chi-bot merged commit a1f44d7 into pingcap:master Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants