Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: fix example topology url 404 #1840

Merged
merged 9 commits into from
Apr 12, 2022
Merged

Conversation

srstack
Copy link
Collaborator

@srstack srstack commented Apr 12, 2022

What problem does this PR solve?

close #1839

@srstack srstack added this to the v1.10.0 milestone Apr 12, 2022
@srstack srstack self-assigned this Apr 12, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 12, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nexustar

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 12, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2022

Codecov Report

Merging #1840 (480710b) into master (bdc10b9) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1840      +/-   ##
==========================================
- Coverage   53.01%   52.96%   -0.05%     
==========================================
  Files         303      303              
  Lines       34682    34682              
==========================================
- Hits        18385    18369      -16     
- Misses      14148    14159      +11     
- Partials     2149     2154       +5     
Flag Coverage Δ
dm 24.73% <ø> (-0.06%) ⬇️
playground 12.64% <ø> (+<0.01%) ⬆️
tiup 14.39% <ø> (ø)
unittest 21.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/api/dmapi.go 59.88% <0.00%> (-4.07%) ⬇️
pkg/cluster/task/update_meta.go 84.95% <0.00%> (-2.15%) ⬇️
pkg/cluster/operation/destroy.go 59.45% <0.00%> (-0.64%) ⬇️
pkg/cluster/api/binlog.go 36.08% <0.00%> (-0.63%) ⬇️
components/dm/spec/topology_dm.go 84.31% <0.00%> (-0.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdc10b9...480710b. Read the comment docs.

@srstack srstack changed the title Issue 1839 cluster: fix example topology url 404 Apr 12, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 12, 2022
@nexustar
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b2debdf

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 12, 2022
@ti-chi-bot ti-chi-bot merged commit 54afc46 into pingcap:master Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cluster: example topology url 404
4 participants