-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mirror: support custom key-dir when rotate root.json #1848
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #1848 +/- ##
==========================================
- Coverage 52.59% 47.01% -5.59%
==========================================
Files 306 306
Lines 34975 35062 +87
==========================================
- Hits 18395 16481 -1914
- Misses 14418 16626 +2208
+ Partials 2162 1955 -207
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 51ddaae
|
What problem does this PR solve?
Add
--key-dir
argument tomirror rotate
subcommandCheck List
Tests
Code changes