Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playground: make playground tag has higher priority than tiup #1869

Merged
merged 2 commits into from
May 9, 2022

Conversation

nexustar
Copy link
Collaborator

@nexustar nexustar commented May 6, 2022

What problem does this PR solve?

  • on tiup: refactor help #1831 , we parser flag of tiup rootCmd manually, if user use tiup playground --tag xxx, tiup cannot Identify the flag and generate a random flag and pass it to playground.

What is changed and how it works?

  • make playground tag has higher priority than tiup
  • make tiup scan the whole args insted of args[0]

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 6, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • srstack

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2022

Codecov Report

Merging #1869 (5815fc6) into master (378989e) will decrease coverage by 0.56%.
The diff coverage is 26.67%.

@@            Coverage Diff             @@
##           master    #1869      +/-   ##
==========================================
- Coverage   52.60%   52.04%   -0.56%     
==========================================
  Files         306      306              
  Lines       35036    35036              
==========================================
- Hits        18430    18233     -197     
- Misses      14441    14629     +188     
- Partials     2165     2174       +9     
Flag Coverage Δ
cluster 40.10% <ø> (-0.82%) ⬇️
dm 24.58% <ø> (ø)
playground 12.78% <44.44%> (+<0.01%) ⬆️
tiup 14.41% <0.00%> (-0.05%) ⬇️
unittest 21.22% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/root.go 55.36% <0.00%> (-1.01%) ⬇️
components/playground/main.go 45.44% <44.44%> (+0.37%) ⬆️
pkg/cluster/api/pdapi.go 46.57% <0.00%> (-14.06%) ⬇️
pkg/cluster/task/update_meta.go 76.34% <0.00%> (-8.60%) ⬇️
pkg/cluster/spec/cdc.go 68.42% <0.00%> (-8.42%) ⬇️
pkg/cluster/task/task.go 64.81% <0.00%> (-8.33%) ⬇️
pkg/tui/cliutil.go 69.77% <0.00%> (-6.98%) ⬇️
pkg/cluster/task/update_topology.go 61.73% <0.00%> (-6.17%) ⬇️
pkg/cluster/operation/scale_in.go 50.00% <0.00%> (-5.13%) ⬇️
pkg/cluster/manager/destroy.go 51.22% <0.00%> (-4.07%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 378989e...5815fc6. Read the comment docs.

@nexustar nexustar added this to the v1.10.0 milestone May 9, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 9, 2022
@nexustar
Copy link
Collaborator Author

nexustar commented May 9, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5815fc6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 9, 2022
@ti-chi-bot
Copy link
Member

@nexustar: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit ebde574 into pingcap:master May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants