-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
playground: make playground tag has higher priority than tiup #1869
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #1869 +/- ##
==========================================
- Coverage 52.60% 52.04% -0.56%
==========================================
Files 306 306
Lines 35036 35036
==========================================
- Hits 18430 18233 -197
- Misses 14441 14629 +188
- Partials 2165 2174 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 5815fc6
|
@nexustar: Your PR was out of date, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
tiup playground --tag xxx
, tiup cannot Identify the flag and generate a random flag and pass it to playground.What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release notes: