Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: add kylin Linux as supported OS #1886

Merged
merged 3 commits into from
May 24, 2022
Merged

Conversation

srstack
Copy link
Collaborator

@srstack srstack commented May 16, 2022

What problem does this PR solve?

close #1865

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@srstack srstack added this to the v1.10.0 milestone May 16, 2022
@srstack srstack self-assigned this May 16, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 16, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2022

Codecov Report

Merging #1886 (b3a4208) into master (60a3af4) will decrease coverage by 3.12%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1886      +/-   ##
==========================================
- Coverage   52.83%   49.71%   -3.12%     
==========================================
  Files         307      306       -1     
  Lines       35165    35126      -39     
==========================================
- Hits        18576    17460    -1116     
- Misses      14400    15562    +1162     
+ Partials     2189     2104      -85     
Flag Coverage Δ
cluster 40.55% <0.00%> (-0.67%) ⬇️
dm ?
playground 12.75% <ø> (ø)
tiup 14.34% <ø> (ø)
unittest 21.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/operation/check.go 47.84% <0.00%> (-0.68%) ⬇️
components/dm/main.go 0.00% <0.00%> (-100.00%) ⬇️
components/dm/spec/bindversion.go 0.00% <0.00%> (-100.00%) ⬇️
components/dm/spec/cluster.go 0.00% <0.00%> (-91.67%) ⬇️
pkg/cluster/template/scripts/dm_worker.go 0.00% <0.00%> (-70.00%) ⬇️
components/dm/spec/logic.go 0.65% <0.00%> (-67.10%) ⬇️
pkg/cluster/template/scripts/dm_master.go 0.00% <0.00%> (-66.29%) ⬇️
pkg/cluster/api/dmapi.go 0.00% <0.00%> (-61.63%) ⬇️
components/dm/command/scale_in.go 9.17% <0.00%> (-53.21%) ⬇️
components/dm/command/prune.go 6.94% <0.00%> (-47.22%) ⬇️
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60a3af4...b3a4208. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 23, 2022
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b3a4208

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 23, 2022
@ti-chi-bot ti-chi-bot merged commit f7d350a into pingcap:master May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tiup check os-version adds support for checking domestic operating systems such as Kylin
4 participants