Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: support RHEL8 #1896

Merged
merged 2 commits into from
May 27, 2022
Merged

cluster: support RHEL8 #1896

merged 2 commits into from
May 27, 2022

Conversation

nexustar
Copy link
Collaborator

What problem does this PR solve?

What is changed and how it works?

I do not know why,but it works.Perhaps that's been the story of SELinux

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 23, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • srstack

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 23, 2022
@AstroProfundis
Copy link
Contributor

If we suggest users to disable SELinux in check, I think it's okay not to workaround it.

Beside, is it possible to add new SELinux rules to allow TiDB components? Will it be too complex?

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2022

Codecov Report

Merging #1896 (2408749) into master (5a9c0b3) will increase coverage by 4.24%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1896      +/-   ##
==========================================
+ Coverage   47.46%   51.70%   +4.24%     
==========================================
  Files         307      307              
  Lines       35454    35454              
==========================================
+ Hits        16825    18329    +1504     
+ Misses      16643    14944    -1699     
- Partials     1986     2181     +195     
Flag Coverage Δ
cluster 39.96% <0.00%> (+7.04%) ⬆️
dm 24.41% <0.00%> (ø)
playground 12.91% <ø> (ø)
tiup 14.45% <ø> (ø)
unittest 21.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/operation/check.go 48.22% <0.00%> (+48.22%) ⬆️
pkg/cluster/operation/scale_in.go 39.74% <0.00%> (-15.38%) ⬇️
pkg/cluster/task/update_meta.go 72.04% <0.00%> (-12.90%) ⬇️
pkg/cluster/task/task.go 64.81% <0.00%> (-8.33%) ⬇️
pkg/cluster/manager/builder.go 66.56% <0.00%> (-6.53%) ⬇️
pkg/cluster/manager/destroy.go 51.22% <0.00%> (-4.07%) ⬇️
pkg/cluster/task/step.go 64.94% <0.00%> (-3.90%) ⬇️
pkg/tui/progress/single_bar.go 84.78% <0.00%> (-3.26%) ⬇️
pkg/cluster/spec/tiflash.go 66.67% <0.00%> (-2.01%) ⬇️
pkg/cluster/spec/tidb.go 62.59% <0.00%> (-1.44%) ⬇️
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a9c0b3...2408749. Read the comment docs.

@nexustar nexustar added this to the v1.10.0 milestone May 23, 2022
@nexustar
Copy link
Collaborator Author

nexustar commented May 23, 2022

If we suggest users to disable SELinux in check, I think it's okay not to workaround it.

Beside, is it possible to add new SELinux rules to allow TiDB components? Will it be too complex?

need to run sudo chcon -t bin_t /tidb-deploy/pd-2379/scripts/run_pd.sh for all component.Since not all systemd has SELinux,it may be too complex to add it to tiup-cluster code.If user do not accept disabling SELinux,he will need to use tiup cluster exec and 2-step scale-out.So I think we should use workaround in this PR

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 25, 2022
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2408749

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 27, 2022
@ti-chi-bot ti-chi-bot merged commit 3601564 into pingcap:master May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tiup support to deploy tidb 6.1 on Red hat enterprise linux 8
5 participants