Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fillHostArchOrOS not working when using Identity #1914

Conversation

srstack
Copy link
Collaborator

@srstack srstack commented Jun 9, 2022

What problem does this PR solve?

close #1913
fix fillHostArchOrOS not working when using Identity

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@srstack srstack self-assigned this Jun 9, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 9, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 9, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2022

Codecov Report

Merging #1914 (355ad3a) into master (16c5f6b) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1914      +/-   ##
==========================================
+ Coverage   52.51%   52.53%   +0.02%     
==========================================
  Files         307      307              
  Lines       35456    35454       -2     
==========================================
+ Hits        18618    18625       +7     
+ Misses      14641    14634       -7     
+ Partials     2197     2195       -2     
Flag Coverage Δ
cluster 41.11% <100.00%> (+0.03%) ⬆️
dm 24.45% <100.00%> (-0.01%) ⬇️
playground 12.91% <ø> (ø)
tiup 14.45% <ø> (ø)
unittest 21.04% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/manager/manager.go 72.56% <100.00%> (-0.33%) ⬇️
pkg/cluster/api/pdapi.go 59.05% <0.00%> (+1.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16c5f6b...355ad3a. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 9, 2022
@AstroProfundis
Copy link
Contributor

/hold

we'll need to do some more tests against this issue

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2022
@AstroProfundis
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2022
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 355ad3a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 9, 2022
@ti-chi-bot ti-chi-bot merged commit 7b32405 into pingcap:master Jun 9, 2022
@AstroProfundis AstroProfundis added this to the 1.10.1 milestone Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tiup v1.10.0 gets Error: failed to fetch cpu-arch or kernel-name: executor.ssh.execute_failed
4 participants