-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
playground: Supports TiKV-CDC component #2000
Merged
Merged
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
4a042ef
wip
pingyu 00f9068
add integration test
pingyu 72de4e3
refine codes
pingyu c521e87
Merge branch 'master' into tikv-cdc-component
pingyu 56d20c0
fix CI error
pingyu 3f4e691
change default porrt
pingyu 34e7745
Merge branch 'master' into tikv-cdc-component
pingyu c28943f
Merge branch 'master' into tikv-cdc-component
pingyu c741e0c
Merge branch 'master' into tikv-cdc-component
pingyu 72f047d
Merge branch 'master' into tikv-cdc-component
pingyu 6b17846
Merge branch 'master' into tikv-cdc-component
pingyu e5f094d
fix CI error
pingyu 52bf78f
address comment
pingyu 6f5d5a7
merge tikv-cdc test
pingyu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| // Copyright 2022 PingCAP, Inc. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package instance | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
| "path/filepath" | ||
| "strings" | ||
|
|
||
| tiupexec "github.com/pingcap/tiup/pkg/exec" | ||
| "github.com/pingcap/tiup/pkg/utils" | ||
| ) | ||
|
|
||
| // TiKVCDC represent a TiKV-CDC instance. | ||
| type TiKVCDC struct { | ||
| instance | ||
| pds []*PDInstance | ||
| Process | ||
| } | ||
|
|
||
| var _ Instance = &TiKVCDC{} | ||
|
|
||
| // NewTiKVCDC create a TiKVCDC instance. | ||
| func NewTiKVCDC(binPath string, dir, host, configPath string, id int, pds []*PDInstance) *TiKVCDC { | ||
| tikvCdc := &TiKVCDC{ | ||
| instance: instance{ | ||
| BinPath: binPath, | ||
| ID: id, | ||
| Dir: dir, | ||
| Host: host, | ||
| Port: utils.MustGetFreePort(host, 8600), | ||
| ConfigPath: configPath, | ||
| }, | ||
| pds: pds, | ||
| } | ||
| tikvCdc.StatusPort = tikvCdc.Port | ||
| return tikvCdc | ||
| } | ||
|
|
||
| // Start implements Instance interface. | ||
| func (c *TiKVCDC) Start(ctx context.Context, version utils.Version) error { | ||
| endpoints := pdEndpoints(c.pds, true) | ||
|
|
||
| args := []string{ | ||
| "server", | ||
| fmt.Sprintf("--addr=%s:%d", c.Host, c.Port), | ||
| fmt.Sprintf("--advertise-addr=%s:%d", AdvertiseHost(c.Host), c.Port), | ||
| fmt.Sprintf("--pd=%s", strings.Join(endpoints, ",")), | ||
| fmt.Sprintf("--log-file=%s", c.LogFile()), | ||
| fmt.Sprintf("--data-dir=%s", filepath.Join(c.Dir, "data")), | ||
| } | ||
| if c.ConfigPath != "" { | ||
| args = append(args, fmt.Sprintf("--config=%s", c.ConfigPath)) | ||
| } | ||
|
|
||
| var err error | ||
| if c.BinPath, err = tiupexec.PrepareBinary("tikv-cdc", version, c.BinPath); err != nil { | ||
| return err | ||
| } | ||
| c.Process = &process{cmd: PrepareCommand(ctx, c.BinPath, args, nil, c.Dir)} | ||
|
|
||
| logIfErr(c.Process.SetOutputFile(c.LogFile())) | ||
| return c.Process.Start() | ||
| } | ||
|
|
||
| // Component return component name. | ||
| func (c *TiKVCDC) Component() string { | ||
| return "tikv-cdc" | ||
| } | ||
|
|
||
| // LogFile return the log file. | ||
| func (c *TiKVCDC) LogFile() string { | ||
| return filepath.Join(c.Dir, "tikv_cdc.log") | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the difference between
cdcandtikv-cdc? This is added to thecluster/specpackage, so doestiup-clusterneed to be aware of the new component as well?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tikv-cdcis another CDC frame but focus on NoSQL scenario, whilecdcfocus on SQL database. Please refer to https://github.com/tikv/migration/blob/main/cdc/README.md.tiup-clusterneed to be aware of the new component as well, please see #2022.