Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: remove tombstone nodes on pd when prune #2044

Merged
merged 9 commits into from
Jun 25, 2024

Conversation

nexustar
Copy link
Collaborator

@nexustar nexustar commented Sep 22, 2022

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 22, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • srstack

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 22, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.20%. Comparing base (901a375) to head (ff025bd).
Report is 1 commits behind head on master.

Current head ff025bd differs from pull request most recent head 3e70ac2

Please upload reports for the commit 3e70ac2 to get more accurate results.

❗ There is a different number of reports uploaded between BASE (901a375) and HEAD (ff025bd). Click for more details.

HEAD has 4 uploads less than BASE | Flag | BASE (901a375) | HEAD (ff025bd) | |------|------|------| |tiup|4|1| |cluster|7|6|
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2044      +/-   ##
==========================================
- Coverage   55.03%   49.20%   -5.83%     
==========================================
  Files         334      324      -10     
  Lines       35925    36682     +757     
==========================================
- Hits        19771    18048    -1723     
- Misses      13773    16320    +2547     
+ Partials     2381     2314      -67     
Flag Coverage Δ
cluster 44.21% <100.00%> (-0.06%) ⬇️
playground 15.25% <0.00%> (-0.86%) ⬇️
tiup 33.50% <ø> (-0.24%) ⬇️
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nexustar nexustar added this to the 1.11.1 milestone Sep 22, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 30, 2022
@srstack srstack self-requested a review October 12, 2022 16:39
@srstack srstack removed the status/LGT1 Indicates that a PR has LGTM 1. label Oct 12, 2022
@nexustar nexustar modified the milestones: 1.11.1 , 1.12.0 Nov 8, 2022
@kaaaaaaang kaaaaaaang modified the milestones: 1.12.0, 1.13.0 Feb 16, 2023
@kaaaaaaang kaaaaaaang modified the milestones: 1.13.0, Next Aug 10, 2023
@kaaaaaaang kaaaaaaang modified the milestones: Next, v1.14.0, v1.15.0 Nov 15, 2023
@kaaaaaaang kaaaaaaang closed this Mar 6, 2024
@kaaaaaaang kaaaaaaang reopened this Mar 6, 2024
Copy link
Contributor

ti-chi-bot bot commented Mar 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kaaaaaaang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kaaaaaaang kaaaaaaang changed the title [DNM] cluster: remove tombstone nodes on pd when prune cluster: remove tombstone nodes on pd when prune Jun 25, 2024
@kaaaaaaang kaaaaaaang closed this Jun 25, 2024
@kaaaaaaang kaaaaaaang reopened this Jun 25, 2024
@kaaaaaaang kaaaaaaang merged commit 8f7230f into pingcap:master Jun 25, 2024
26 of 36 checks passed
@kaaaaaaang kaaaaaaang modified the milestones: v1.15.0, v1.16.0 Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
5 participants