Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

component/playground: rm the restriction that tikv num must be greater than 0 #2073

Merged
merged 4 commits into from
Nov 14, 2022
Merged

component/playground: rm the restriction that tikv num must be greater than 0 #2073

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
91b24ee
component/playground: rm the restriction that tikv num must be greate…
lilinghai Nov 9, 2022
1951e96
component/playground: rm the restriction that tikv num must be greate…
lilinghai Nov 9, 2022
9cbf943
Merge branch 'refine-playground-comp-num' of github.com:lilinghai/tiu…
lilinghai Nov 9, 2022
02f2ecd
Merge branch 'master' into refine-playground-comp-num
ti-chi-bot Nov 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions components/playground/playground.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -814,8 +814,9 @@ func (p *Playground) bootCluster(ctx context.Context, env *environment.Environme

p.bootOptions = options

if options.PD.Num < 1 || options.TiKV.Num < 1 {
return fmt.Errorf("all components count must be great than 0 (tikv=%v, pd=%v)", options.TiKV.Num, options.PD.Num)
// All others components depend on the pd, we just ensure the pd count must be great than 0
if options.PD.Num < 1 {
return fmt.Errorf("all components count must be great than 0 (pd=%v)", options.PD.Num)
}

if !utils.Version(options.Version).IsNightly() {
Expand Down