-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
playground: Code refine for args #2178
Conversation
Signed-off-by: Wish <breezewish@outlook.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2178 +/- ##
==========================================
+ Coverage 56.06% 56.24% +0.18%
==========================================
Files 317 317
Lines 33578 33454 -124
==========================================
- Hits 18824 18814 -10
+ Misses 12504 12396 -108
+ Partials 2250 2244 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
/merge |
@breezewish: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: e760aec
|
What problem does this PR solve?
There are many duplicate codes when introducing new args in TiUP Playground.
What is changed and how it works?
Keep code dry.
This PR is more like a re-implementation of #1365 in another way.
Check List
Tests
A simple test about how
options
looks like now afterpopulateDefaultOpt
:Code changes
Side effects
Related changes
Release notes: