Upgrade TiCDC before TiKV and PD when cluster is equal or greater than v5.1.0 #2253

KanShiori · 2023-08-17T08:39:52Z

What problem does this PR solve?

Close #2166

What is changed and how it works?

Upgrade TiCDC before TiKV and PD when cluster is equal or greater than v5.1.0

Check List

Tests

Manual test (add detailed scripts or steps below)

Upgrade cluster from v5.0.0 to v.5.2.0

$ ./tiup-cluster upgrade my-cluster v5.2.0
This operation will upgrade tidb v5.0.0 cluster my-cluster to v5.2.0.
...
Upgrading component pd
        Restarting instance 127.0.0.1:2379
        Restart instance 127.0.0.1:2379 success
Upgrading component tikv
        Restarting instance 127.0.0.1:20160
        Restart instance 127.0.0.1:20160 success
Upgrading component tidb
        Restarting instance 127.0.0.1:4000
        Restart instance 127.0.0.1:4000 success
Upgrading component cdc
        Restarting instance 127.0.0.1:8300
        Restart instance 127.0.0.1:8300 success
...

Upgrade cluster from v5.1.0 to v5.2.0

$ ./tiup-cluster upgrade my-cluster v5.2.0
This operation will upgrade tidb v5.1.0 cluster my-cluster to v5.2.0.
...
Upgrading component cdc
        Restarting instance 127.0.0.1:8300
        Restart instance 127.0.0.1:8300 success
Upgrading component pd
        Restarting instance 127.0.0.1:2379
        Restart instance 127.0.0.1:2379 success
Upgrading component tikv
        Restarting instance 127.0.0.1:20160
        Restart instance 127.0.0.1:20160 success
Upgrading component tidb
        Restarting instance 127.0.0.1:4000
        Restart instance 127.0.0.1:4000 success
...

Upgrade cluster from v5.2.0 to v5.3.0

$  ./tiup-cluster upgrade my-cluster v5.3.0
This operation will upgrade tidb v5.2.0 cluster my-cluster to v5.3.0.
...
Upgrading component cdc
        Restarting instance 127.0.0.1:8300
        Restart instance 127.0.0.1:8300 success
Upgrading component pd
        Restarting instance 127.0.0.1:2379
        Restart instance 127.0.0.1:2379 success
Upgrading component tikv
        Restarting instance 127.0.0.1:20160
        Restart instance 127.0.0.1:20160 success
Upgrading component tidb
        Restarting instance 127.0.0.1:4000
...

Release notes:

Upgrade TiCDC before TiKV and PD when cluster is equal or greater than v5.1.0

CLAassistant · 2023-08-17T08:39:57Z

All committers have signed the CLA.

codecov-commenter · 2023-08-17T08:43:17Z

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2feb74b) 55.98% compared to head (0a44220) 55.98%.

❗ Current head 0a44220 differs from pull request most recent head 9fb8404. Consider uploading reports for the commit 9fb8404 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2253   +/-   ##
=======================================
  Coverage   55.98%   55.98%           
=======================================
  Files         320      320           
  Lines       33881    33891   +10     
=======================================
+ Hits        18965    18971    +6     
- Misses      12648    12651    +3     
- Partials     2268     2269    +1

Flag	Coverage Δ
cluster	`44.82% <100.00%> (+0.02%)`	⬆️
dm	`25.69% <17.65%> (-0.06%)`	⬇️
playground	`15.70% <0.00%> (-0.01%)`	⬇️
tiup	`15.86% <0.00%> (-0.01%)`	⬇️
unittest	`22.64% <0.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
components/dm/spec/logic.go	`70.00% <100.00%> (ø)`
pkg/cluster/manager/check.go	`69.41% <100.00%> (ø)`
pkg/cluster/manager/upgrade.go	`57.29% <100.00%> (ø)`
pkg/cluster/operation/upgrade.go	`47.14% <100.00%> (ø)`
pkg/cluster/spec/spec.go	`83.60% <100.00%> (+0.27%)`	⬆️
pkg/tidbver/tidbver.go	`90.16% <100.00%> (+0.33%)`	⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Rustin170506

LGTM

pkg/tidbver/tidbver.go

ti-chi-bot · 2023-08-18T06:11:58Z

@hi-rustin: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Rustin170506 · 2023-08-18T08:08:34Z

/cc @sdojjy

/hold

ti-chi-bot · 2023-08-18T08:08:36Z

@hi-rustin: GitHub didn't allow me to request PR reviews from the following users: sdojjy.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @sdojjy

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot · 2023-08-18T16:48:41Z

@sdojjy: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot · 2023-08-21T03:11:23Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hi-rustin, kaaaaaaang, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [kaaaaaaang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2023-08-21T03:11:25Z

[LGTM Timeline notifier]

Timeline:

2023-08-20 18:08:47.379936525 +0000 UTC m=+1086491.928952513: ☑️ agreed by kaaaaaaang.
2023-08-21 02:12:50.650689687 +0000 UTC m=+1115535.199705659: ✖️🔁 reset by KanShiori.
2023-08-21 03:11:24.211567308 +0000 UTC m=+1119048.760583295: ☑️ agreed by kaaaaaaang.

kaaaaaaang · 2023-08-21T03:42:01Z

/merge

KanShiori added 2 commits August 17, 2023 07:54

add cur version and new version in ComponentsByUpdateOrder

910fbc7

upgrade tikv firstly when cluster is greater then v5.1.0

440e2aa

ti-chi-bot bot requested review from breezewish and srstack August 17, 2023 08:39

ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 17, 2023

add comment

8e58dfd

Rustin170506 approved these changes Aug 18, 2023

View reviewed changes

pkg/tidbver/tidbver.go Outdated Show resolved Hide resolved

address comment

662fcb5

ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 18, 2023

sdojjy approved these changes Aug 18, 2023

View reviewed changes

kaaaaaaang approved these changes Aug 20, 2023

View reviewed changes

ti-chi-bot bot added lgtm approved labels Aug 20, 2023

Merge branch 'master' into shiori/cdc-upgrade-compatibility

9fb8404

ti-chi-bot bot removed the lgtm label Aug 21, 2023

kaaaaaaang approved these changes Aug 21, 2023

View reviewed changes

ti-chi-bot bot added the lgtm label Aug 21, 2023

kaaaaaaang removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 21, 2023

ti-chi-bot bot merged commit af2aa2a into pingcap:master Aug 21, 2023
16 checks passed

KanShiori deleted the shiori/cdc-upgrade-compatibility branch August 21, 2023 05:46

kaaaaaaang added this to the 1.13.0 milestone Aug 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade TiCDC before TiKV and PD when cluster is equal or greater than v5.1.0 #2253

Upgrade TiCDC before TiKV and PD when cluster is equal or greater than v5.1.0 #2253

KanShiori commented Aug 17, 2023 •

edited

Loading

CLAassistant commented Aug 17, 2023 •

edited

Loading

codecov-commenter commented Aug 17, 2023 •

edited

Loading

Rustin170506 left a comment

ti-chi-bot bot commented Aug 18, 2023

Rustin170506 commented Aug 18, 2023

ti-chi-bot bot commented Aug 18, 2023

ti-chi-bot bot commented Aug 18, 2023

ti-chi-bot bot commented Aug 21, 2023

ti-chi-bot bot commented Aug 21, 2023

kaaaaaaang commented Aug 21, 2023

Upgrade TiCDC before TiKV and PD when cluster is equal or greater than v5.1.0 #2253

Upgrade TiCDC before TiKV and PD when cluster is equal or greater than v5.1.0 #2253

Conversation

KanShiori commented Aug 17, 2023 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

CLAassistant commented Aug 17, 2023 • edited Loading

codecov-commenter commented Aug 17, 2023 • edited Loading

Codecov Report

Rustin170506 left a comment

Choose a reason for hiding this comment

ti-chi-bot bot commented Aug 18, 2023

Rustin170506 commented Aug 18, 2023

ti-chi-bot bot commented Aug 18, 2023

ti-chi-bot bot commented Aug 18, 2023

ti-chi-bot bot commented Aug 21, 2023

ti-chi-bot bot commented Aug 21, 2023

[LGTM Timeline notifier]

kaaaaaaang commented Aug 21, 2023

KanShiori commented Aug 17, 2023 •

edited

Loading

CLAassistant commented Aug 17, 2023 •

edited

Loading

codecov-commenter commented Aug 17, 2023 •

edited

Loading